Skip to content

PPHA-747: Confirmation page content changes#402

Merged
jamiefalcus merged 3 commits intomainfrom
PPHA-747-confirmation-page-content-changes
Mar 25, 2026
Merged

PPHA-747: Confirmation page content changes#402
jamiefalcus merged 3 commits intomainfrom
PPHA-747-confirmation-page-content-changes

Conversation

@jamiefalcus
Copy link
Copy Markdown
Contributor

What is the change?

Updating confirmation page to match design

Why are we making this change?

So that the confirmation page is as UCD intended.

Copilot AI review requested due to automatic review settings March 24, 2026 16:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the confirmation page UI/content so it matches the intended UCD design, including typography tweaks and an added feedback CTA, and adds an accessibility regression check for the page.

Changes:

  • Adjust confirmation page headings/content and add a “Give feedback” button linking to the NHS feedback form.
  • Add a small Sass “shim” to render the panel title at the desired size, and wire it into the main Sass entrypoint.
  • Add a new Behave feature scenario asserting the confirmation page has no Axe accessibility violations.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
lung_cancer_screening/questions/jinja2/confirmation.jinja Updates confirmation page content/typography and adds a feedback button.
lung_cancer_screening/assets/sass/main.scss Includes the new panel title shim in the compiled CSS bundle.
lung_cancer_screening/assets/sass/components/_panel_title_shim.scss Adds CSS to adjust the panel title size.
features/confirmation.feature Adds an accessibility check scenario for the confirmation page.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lung_cancer_screening/questions/jinja2/confirmation.jinja Outdated
Comment thread features/confirmation.feature Outdated
@jamiefalcus jamiefalcus force-pushed the PPHA-747-confirmation-page-content-changes branch from 004781c to 4ae4274 Compare March 24, 2026 17:00
@jamiefalcus jamiefalcus changed the title Updates to make confirmation match design PPHA-747: Confirmation page content changes Mar 24, 2026
@sonarqubecloud
Copy link
Copy Markdown

@jamiefalcus jamiefalcus merged commit 771aa7f into main Mar 25, 2026
25 checks passed
@jamiefalcus jamiefalcus deleted the PPHA-747-confirmation-page-content-changes branch March 25, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants