Skip to content

Enforce eligibility user journey #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamiefalcus merged 7 commits into from
Jan 23, 2026
Merged

Enforce eligibility user journey #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd8eca1
Move pre view check mixins into each view independently
Themitchell Jan 22, 2026
92514be
Force user to answer smoking question before answering date of birth
Themitchell Jan 23, 2026
cb54080
Add eligibility methods to models
Themitchell Jan 23, 2026
ecb8ec3
Ensure all non eligibility questions can only be answered when eligible
Themitchell Jan 23, 2026
b9abce2
Ensure CheckNeedAppointment requires DOB to be answered
Themitchell Jan 23, 2026
ea9bd3b
fixup! Ensure all non eligibility questions can only be answered when…
Themitchell Jan 23, 2026
1874502
Fix wording of submitted redirect tests
Themitchell Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions features/age_when_started_smoking.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
Feature: Age when started smoking
Scenario: The page is accessible
Given I am logged in
And I am 60 years old
And I have answered questions showing I am eligible
When I go to "/age-when-started-smoking"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
And I am 60 years old
When I go to "/age-when-started-smoking"
And I click "Continue"
Expand All @@ -21,15 +22,15 @@ Feature: Age when started smoking

Scenario: Navigating backwards and forwards
Given I am logged in
And I am 60 years old
And I have answered questions showing I am eligible
When I go to "/age-when-started-smoking"
Then I see a back link to "/relatives-age-when-diagnosed"
When I fill in "How old were you when you started smoking?" as "18" and submit
Then I am on "/check-your-answers"

Scenario: Checking responses and changing them
Given I am logged in
And I am 60 years old
And I have answered questions showing I am eligible
When I go to "/age-when-started-smoking"
And I fill in "How old were you when you started smoking?" as "18" and submit
When I go to "/check-your-answers"
Expand Down
9 changes: 9 additions & 0 deletions features/asbestos_exposure.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
Feature: Asbestos exposure page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/asbestos-exposure"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/asbestos-exposure"
And I click "Continue"
Then I am on "/asbestos-exposure"
Expand All @@ -15,13 +17,15 @@ Feature: Asbestos exposure page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/asbestos-exposure"
Then I see a back link to "/respiratory-conditions"
When I fill in and submit my asbestos exposure with "No"
Then I am on "/cancer-diagnosis"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/asbestos-exposure"
And I fill in and submit my asbestos exposure with "No"
When I go to "/check-your-answers"
Expand All @@ -33,3 +37,8 @@ Feature: Asbestos exposure page
When I fill in and submit my asbestos exposure with "Yes"
Then I am on "/check-your-answers"
And I see "Yes" as a response to "Have you ever worked in a job where you were exposed to asbestos?" under "Your health"

Scenario: Cannot answer when ineligible
Given I am logged in
When I go to "/asbestos-exposure"
Then I am on "/have-you-ever-smoked"
4 changes: 4 additions & 0 deletions features/cancer_diagnosis.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
Feature: Cancer diagnosis page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/cancer-diagnosis"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/cancer-diagnosis"
And I click "Continue"
Then I am on "/cancer-diagnosis"
Expand All @@ -15,13 +17,15 @@ Feature: Cancer diagnosis page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/cancer-diagnosis"
Then I see a back link to "/asbestos-exposure"
When I fill in and submit my cancer diagnosis with "No"
Then I am on "/family-history-lung-cancer"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/cancer-diagnosis"
And I fill in and submit my cancer diagnosis with "No"
When I go to "/check-your-answers"
Expand Down
10 changes: 10 additions & 0 deletions features/check_need_appointment.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@
Feature: Check if you need an appointment page
Scenario: The page is accessible
Given I am logged in
And I have answered have you ever smoked with an eligible response
And I have answered date of birth with an eligible date of birth
When I go to "/check-if-you-need-an-appointment"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered have you ever smoked with an eligible response
And I have answered date of birth with an eligible date of birth
When I go to "/check-if-you-need-an-appointment"
And I click "Continue"
Then I am on "/check-if-you-need-an-appointment"
Expand All @@ -15,20 +19,26 @@ Feature: Check if you need an appointment page

Scenario: Eligibility exit if needs face to face appointment
Given I am logged in
And I have answered have you ever smoked with an eligible response
And I have answered date of birth with an eligible date of birth
When I go to "/check-if-you-need-an-appointment"
Then I see a back link to "/date-of-birth"
When I check "Yes, one or more of these things applies to me and I need a face-to-face appointment" and submit
Then I am on "/call-us-to-book-an-appointment"

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered have you ever smoked with an eligible response
And I have answered date of birth with an eligible date of birth
When I go to "/check-if-you-need-an-appointment"
Then I see a back link to "/date-of-birth"
When I check "No, I can continue online" and submit
Then I am on "/height"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered have you ever smoked with an eligible response
And I have answered date of birth with an eligible date of birth
When I go to "/check-if-you-need-an-appointment"
And I check "No, I can continue online" and submit
When I click "Back"
Expand Down
5 changes: 5 additions & 0 deletions features/date_of_birth_page.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
Feature: Date of birth page
Scenario: The page is accessible
Given I am logged in
And I have answered have you ever smoked with an eligible response
When I go to "/date-of-birth"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have started the questionnaire
And I have answered have you ever smoked with an eligible response
When I go to "/date-of-birth"
When I click "Continue"
Then I am on "/date-of-birth"
Expand All @@ -25,20 +27,23 @@ Feature: Date of birth page

Scenario: Eligibility of people not in age range
Given I am logged in
And I have answered have you ever smoked with an eligible response
When I go to "/date-of-birth"
And I fill in and submit my date of birth with "01-01-1900"
Then I am on "/age-range-exit"
And I see a title "You are not eligible for lung cancer screening"

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered have you ever smoked with an eligible response
When I go to "/date-of-birth"
Then I see a back link to "/have-you-ever-smoked"
When I fill in and submit my date of birth as 55 years ago
Then I am on "/check-if-you-need-an-appointment"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered have you ever smoked with an eligible response
When I go to "/date-of-birth"
And I fill in and submit my date of birth as 55 years ago
When I go to "/check-your-answers"
Expand Down
4 changes: 4 additions & 0 deletions features/education.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
Feature: Education page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/education"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/education"
And I click "Continue"
Then I am on "/education"
Expand All @@ -15,6 +17,7 @@ Feature: Education page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/education"
Then I see a back link to "/ethnicity"
When I check "A-levels"
Expand All @@ -23,6 +26,7 @@ Feature: Education page

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/education"
And I check "A-levels"
And I check "GCSEs"
Expand Down
4 changes: 4 additions & 0 deletions features/ethnicity.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
Feature: Ethnicity page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/ethnicity"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/ethnicity"
And I click "Continue"
Then I am on "/ethnicity"
Expand All @@ -15,13 +17,15 @@ Feature: Ethnicity page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/ethnicity"
Then I see a back link to "/gender"
When I fill in and submit my ethnicity with "White"
Then I am on "/education"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/ethnicity"
And I fill in and submit my ethnicity with "White"
When I go to "/check-your-answers"
Expand Down
4 changes: 4 additions & 0 deletions features/family_history_lung_cancer.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
Feature: Family history of lung cancer page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
And I click "Continue"
Then I am on "/family-history-lung-cancer"
Expand All @@ -15,6 +17,7 @@ Feature: Family history of lung cancer page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
Then I see a back link to "/cancer-diagnosis"
When I fill in and submit my family history lung cancer with "No"
Expand All @@ -25,6 +28,7 @@ Feature: Family history of lung cancer page

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
And I fill in and submit my family history lung cancer with "No"
When I go to "/check-your-answers"
Expand Down
4 changes: 4 additions & 0 deletions features/gender.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
Feature: Gender page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/gender"
Then there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/gender"
And I click "Continue"
Then I am on "/gender"
Expand All @@ -15,13 +17,15 @@ Feature: Gender page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/gender"
Then I see a back link to "/sex-at-birth"
When I fill in and submit my gender with "Female"
Then I am on "/ethnicity"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/gender"
And I fill in and submit my gender with "Female"
When I go to "/check-your-answers"
Expand Down
5 changes: 5 additions & 0 deletions features/height.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
Feature: Height page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/height"
Then there are no accessibility violations
When I click "Switch to feet and inches"
Then there are no accessibility violations

Scenario: Metric form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/height"
And I click "Continue"
Then I am on "/height"
Expand All @@ -23,6 +25,7 @@ Feature: Height page

Scenario: Imperial form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/height?unit=imperial"
And I click "Continue"
Then I am on "/height?unit=imperial"
Expand All @@ -40,6 +43,7 @@ Feature: Height page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/height"
Then I see a back link to "/check-if-you-need-an-appointment"
When I fill in and submit my height with "170"
Expand All @@ -53,6 +57,7 @@ Feature: Height page

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/height"
And I fill in and submit my height with "170"
When I go to "/check-your-answers"
Expand Down
5 changes: 5 additions & 0 deletions features/relatives_age_when_diagnosed.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
Feature: Relatives age when diagnosed page
Scenario: The page is accessible
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
And I fill in and submit my family history lung cancer with "Yes"
Then I am on "/relatives-age-when-diagnosed"
And there are no accessibility violations

Scenario: Form errors
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
And I fill in and submit my family history lung cancer with "Yes"
Then I am on "/relatives-age-when-diagnosed"
Expand All @@ -19,6 +21,7 @@ Feature: Relatives age when diagnosed page

Scenario: Navigating backwards and forwards
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
And I fill in and submit my family history lung cancer with "Yes"
Then I am on "/relatives-age-when-diagnosed"
Expand All @@ -28,11 +31,13 @@ Feature: Relatives age when diagnosed page

Scenario: Redirecting if they have no family history of lung cancer
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/relatives-age-when-diagnosed"
Then I am on "/family-history-lung-cancer"

Scenario: Checking responses and changing them
Given I am logged in
And I have answered questions showing I am eligible
When I go to "/family-history-lung-cancer"
And I fill in and submit my family history lung cancer with "Yes"
And I fill in and submit my relatives age when diagnosed with "Yes, they were younger than 60"
Expand Down
Loading