Only allow GET and POST requests for views#135
Merged
Themitchell merged 1 commit intomainfrom Nov 11, 2025
Merged
Conversation
jamiefalcus
previously approved these changes
Nov 10, 2025
Themitchell
force-pushed
the
fix-csrf-sonarqube-issues
branch
from
5fdbb62 to
e190798
Compare
|
miriam-z
approved these changes
Nov 11, 2025
| from .decorators.participant_decorators import require_participant | ||
| from ..forms.date_of_birth_form import DateOfBirthForm | ||
|
|
||
| @require_http_methods(["GET", "POST"]) |
Contributor
There was a problem hiding this comment.
@require_http_methods/@require_GET decorators are placed above @require_participant. A disallowed-method request will return 405 before any participant logic runs.
Contributor
Author
There was a problem hiding this comment.
If i understand correctly thats the behaviour we want. In other words if someone request the endpoint with an invalid method they are given a 405 as the endpoint does not exist. I suppose an argument could be made for not exposing the that that a PUT does not exist but im not sure we care here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Only allow get (or GET / POST) requests in views
Why are we making this change?
Allowing other requests is a security vulnerability