Fix/config update#112
Merged
Themitchell merged 5 commits intomainfrom Oct 21, 2025
Merged
Conversation
Themitchell
reviewed
Oct 21, 2025
| make dev-run | ||
| ``` | ||
|
|
||
| After starting the application, apply the database migrations: |
Contributor
There was a problem hiding this comment.
Because migrations run through docker compose running make dev-migrate will bring up the postgres container and run the migrations from the web container which means you don't need to start the application first. The docker compose file just habdles the stack for you so theres no interdependency there :)
Contributor
Author
There was a problem hiding this comment.
Sounds good, I will make this edit.
Themitchell
requested changes
Oct 21, 2025
Contributor
Themitchell
left a comment
There was a problem hiding this comment.
Looks good bar the small comment re starting the app before running migrations
Themitchell
approved these changes
Oct 21, 2025
0e0ee49 to
c0af330
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Makefile syntax errors that were preventing proper execution with
.ONESHELLmode, updates the Python version to match the Dockerfile, and improves the README with comprehensive setup instructions.Changes include:
_install-dependenciesand_testtargets with proper line continuations and semicolons.tool-versionsto use Python 3.13.7 (matching Dockerfile).env.examplecopy step and database migration requirementContext
The Makefile targets were failing with "syntax error: unexpected end of file" because the bash commands weren't properly formatted for Make's
.ONESHELLmode. This blocked developers from runningmake configandmake testsuccessfully.Additionally, the README was missing critical setup steps that new developers would need, including:
.env.exampleto.envType of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable
Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain
any sensitive information. We really appreciate your cooperation in this matter.