Make SexAtBirth use simpler view pattern

Author: Themitchell

features/sex_at_birth.feature

@@ -1,3 +1,4 @@
+@SexAtBirth
 Feature: Sex at birth page
   Scenario: The page is accessible
     Given I am logged in
@@ -28,6 +29,7 @@ Feature: Sex at birth page
     And I see "/sex-at-birth?change=True" as a link to change "Sex at birth" under "About you"
     When I click the link to change "Sex at birth" under "About you"
     Then I am on "/sex-at-birth?change=True"
+    And I see "Male" selected
     When I fill in and submit my sex at birth with "Female"
     Then I am on "/check-your-answers"
     And I see "Female" as a response to "Sex at birth" under "About you"

lung_cancer_screening/questions/tests/unit/forms/test_sex_at_birth_form.py

@@ -1,9 +1,11 @@
-from django.test import TestCase
+from django.test import TestCase, tag
 
 from ...factories.response_set_factory import ResponseSetFactory
 from ....models.sex_at_birth_response import SexAtBirthResponse, SexAtBirthValues
 from ....forms.sex_at_birth_form import SexAtBirthForm
 
+
+@tag("SexAtBirth")
 class TestSexAtBirthForm(TestCase):
     def setUp(self):
         self.response_set = ResponseSetFactory()

lung_cancer_screening/questions/tests/unit/models/test_sex_at_birth_response.py

@@ -1,11 +1,12 @@
-from django.test import TestCase
+from django.test import TestCase, tag
 
 from ...factories.response_set_factory import ResponseSetFactory
 from ...factories.sex_at_birth_response_factory import SexAtBirthResponseFactory
 
 from ....models.sex_at_birth_response import SexAtBirthResponse, SexAtBirthValues
 
 
+@tag("SexAtBirth")
 class TestSexAtBirthResponse(TestCase):
     def setUp(self):
         self.response_set = ResponseSetFactory()

lung_cancer_screening/questions/tests/unit/views/test_sex_at_birth.py

@@ -1,4 +1,4 @@
-from django.test import TestCase
+from django.test import TestCase, tag
 from django.urls import reverse
 from dateutil.relativedelta import relativedelta
 from django.utils import timezone
@@ -7,6 +7,7 @@
 from lung_cancer_screening.questions.models.sex_at_birth_response import SexAtBirthResponse, SexAtBirthValues
 
 
+@tag("SexAtBirth")
 class TestGetSexAtBirth(TestCase):
     def setUp(self):
         self.user = login_user(self.client)
@@ -48,6 +49,7 @@ def test_get_contains_the_correct_form_fields(self):
         self.assertContains(response, "What was your sex at birth?")
 
 
+@tag("SexAtBirth")
 class TestPostSexAtBirth(TestCase):
     def setUp(self):
         self.user = login_user(self.client)

lung_cancer_screening/questions/views/sex_at_birth.py

@@ -1,52 +1,13 @@
-from django.shortcuts import render
-from django.urls import reverse
+from django.urls import reverse_lazy
 
 from .question_base_view import QuestionBaseView
 from ..forms.sex_at_birth_form import SexAtBirthForm
 from ..models.sex_at_birth_response import SexAtBirthResponse
 
 
 class SexAtBirthView(QuestionBaseView):
-    def get(self, request):
-        response, _ = SexAtBirthResponse.objects.get_or_build(
-            response_set=request.response_set
-        )
-        return render_template(
-            request,
-            SexAtBirthForm(instance=response)
-        )
-
-    def post(self, request):
-        response, _ = SexAtBirthResponse.objects.get_or_build(
-            response_set=request.response_set
-        )
-        form = SexAtBirthForm(
-            instance=response,
-            data=request.POST
-        )
-
-        if form.is_valid():
-            response.value = form.cleaned_data["value"]
-            response.save()
-            return self.redirect_to_response_or_next_question(
-                request,
-                "questions:gender"
-            )
-        else:
-            return render_template(
-                request,
-                form,
-                status=422
-            )
-
-
-def render_template(request, form, status=200):
-    return render(
-        request,
-        "question_form.jinja",
-        {
-            "form": form,
-            "back_link_url": reverse("questions:weight")
-        },
-        status=status
-    )
+    template_name = "question_form.jinja"
+    form_class = SexAtBirthForm
+    model = SexAtBirthResponse
+    success_url = reverse_lazy("questions:gender")
+    back_link_url = reverse_lazy("questions:weight")