Make RespiratoryConditions use simpler view pattern

Author: Themitchell

features/respiratory_conditions.feature

@@ -1,3 +1,4 @@
+@RespiratoryConditions
 Feature: Respiratory conditions page
   Scenario: The page is accessible
     Given I am logged in
@@ -31,6 +32,8 @@ Feature: Respiratory conditions page
     And I see "/respiratory-conditions?change=True" as a link to change "Diagnosed respiratory conditions" under "Your health"
     When I click the link to change "Diagnosed respiratory conditions" under "Your health"
     Then I am on "/respiratory-conditions?change=True"
+    And I see "Pneumonia" selected
+    And I see "Emphysema" selected
     When I fill in and submit my respiratory conditions with "Bronchitis" and "Tuberculosis (TB)"
     Then I am on "/check-your-answers"
     And I see "Pneumonia, Emphysema, Bronchitis, and Tuberculosis (TB)" as a response to "Diagnosed respiratory conditions" under "Your health"

lung_cancer_screening/questions/tests/unit/forms/test_respiratory_conditions_form.py

@@ -1,10 +1,11 @@
-from django.test import TestCase
+from django.test import TestCase, tag
 
 from ...factories.response_set_factory import ResponseSetFactory
 from ....models.respiratory_conditions_response import RespiratoryConditionsResponse
 from ....forms.respiratory_conditions_form import RespiratoryConditionsForm
 
 
+@tag("RespiratoryConditions")
 class TestRespiratoryConditionsForm(TestCase):
     def setUp(self):
         self.response_set = ResponseSetFactory()

lung_cancer_screening/questions/tests/unit/models/test_respiratory_conditions_response.py

@@ -1,11 +1,12 @@
-from django.test import TestCase
+from django.test import TestCase, tag
 
 from ...factories.response_set_factory import ResponseSetFactory
 from ...factories.respiratory_conditions_response_factory import RespiratoryConditionsResponseFactory
 
 from ....models.respiratory_conditions_response import RespiratoryConditionsResponse, RespiratoryConditionValues
 
 
+@tag("RespiratoryConditions")
 class TestRespiratoryConditionsResponse(TestCase):
     def setUp(self):
         self.response_set = ResponseSetFactory()

lung_cancer_screening/questions/tests/unit/views/test_respiratory_conditions.py

@@ -1,4 +1,4 @@
-from django.test import TestCase
+from django.test import TestCase, tag
 from django.urls import reverse
 from dateutil.relativedelta import relativedelta
 from django.utils import timezone
@@ -7,6 +7,7 @@
 from lung_cancer_screening.questions.models.respiratory_conditions_response import RespiratoryConditionsResponse
 
 
+@tag("RespiratoryConditions")
 class TestGetRespiratoryConditions(TestCase):
     def setUp(self):
         self.user = login_user(self.client)
@@ -65,6 +66,7 @@ def test_get_contains_the_correct_form_fields(self):
         )
 
 
+@tag("RespiratoryConditions")
 class TestPostRespiratoryConditions(TestCase):
     def setUp(self):
         self.user = login_user(self.client)

lung_cancer_screening/questions/views/respiratory_conditions.py

@@ -1,52 +1,13 @@
-from django.shortcuts import render
-from django.urls import reverse
+from django.urls import reverse_lazy
 
 from .question_base_view import QuestionBaseView
 from ..forms.respiratory_conditions_form import RespiratoryConditionsForm
 from ..models.respiratory_conditions_response import RespiratoryConditionsResponse
 
 
 class RespiratoryConditionsView(QuestionBaseView):
-    def get(self, request):
-        response, _ = RespiratoryConditionsResponse.objects.get_or_build(
-            response_set=request.response_set
-        )
-        return render_template(
-            request,
-            RespiratoryConditionsForm(instance=response)
-        )
-
-    def post(self, request):
-        response, _ = RespiratoryConditionsResponse.objects.get_or_build(
-            response_set=request.response_set
-        )
-        form = RespiratoryConditionsForm(
-            instance=response,
-            data=request.POST
-        )
-
-        if form.is_valid():
-            response.value = form.cleaned_data["value"]
-            response.save()
-            return self.redirect_to_response_or_next_question(
-                request,
-                "questions:asbestos_exposure"
-            )
-        else:
-            return render_template(
-                request,
-                form,
-                status=422
-            )
-
-
-def render_template(request, form, status=200):
-    return render(
-        request,
-        "question_form.jinja",
-        {
-            "form": form,
-            "back_link_url": reverse("questions:education")
-        },
-        status=status
-    )
+    template_name = "question_form.jinja"
+    form_class = RespiratoryConditionsForm
+    model = RespiratoryConditionsResponse
+    success_url = reverse_lazy("questions:asbestos_exposure")
+    back_link_url = reverse_lazy("questions:education")