Skip to content

Replacing Instant.now() with timestampService.now()#1461

Open
ORybak5 wants to merge 13 commits intomainfrom
instant-time-refactoring
Open

Replacing Instant.now() with timestampService.now()#1461
ORybak5 wants to merge 13 commits intomainfrom
instant-time-refactoring

Conversation

@ORybak5
Copy link
Copy Markdown
Contributor

@ORybak5 ORybak5 commented Apr 23, 2026

What

Replacing the instances of Instant.now() with timestampService.now() to make it calling from "one source of truth"

Why

Centralizes time access by calling Instant.now() from a dedicated provider, improving consistency across the codebase.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@ORybak5 ORybak5 marked this pull request as ready for review April 23, 2026 14:40
@ORybak5 ORybak5 requested a review from a team as a code owner April 23, 2026 14:40
@github-actions
Copy link
Copy Markdown

Looks good. All 2 mutations in this change were killed.

class surviving killed
💯uk.nhs.adaptors.gp2gp.ehr.EhrExtractStatusService 0 2

See https://pitest.org

Copy link
Copy Markdown
Contributor

@chiaramapellimt chiaramapellimt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants