Skip to content

Refactor AllergyStructureMapper #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MartinWheelerMT wants to merge 3 commits into
base: main
Choose a base branch
from

* Fix issue with `null` allocation for enum allocation

25d8132
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Refactor AllergyStructureMapper #1430

* Fix issue with `null` allocation for enum allocation
25d8132
Select commit
Loading
Failed to load commit list.
GitHub Actions / pitest completed Jan 21, 2026 in 1s

Pitest mutation testing feedback

  • Surviving mutants in this change: 16
  • Killed mutants in this change: 76
class surviving killed
🧟uk.nhs.adaptors.gp2gp.ehr.mapper.PertinentInformationAllergyMapper 9 40
🧟uk.nhs.adaptors.gp2gp.ehr.mapper.AllergyStructureMapper 7 36

See https://pitest.org

Annotations

Check warning on line 107 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 107 without causing a test to fail 

removed call to filter (covered by 4 tests RemoveFilterMutator)

Check warning on line 105 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 105 without causing a test to fail 

removed call to filter (covered by 4 tests RemoveFilterMutator)

Check warning on line 78 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

2 different changes can be made to line 78 without causing a test to fail 

removed conditional - replaced equality check with false (covered by 40 tests RemoveConditionalMutator_EQUAL_ELSE)
removed conditional - replaced equality check with true (covered by 40 tests RemoveConditionalMutator_EQUAL_IF)

Check warning on line 72 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 72 without causing a test to fail 

removed conditional - replaced equality check with true (covered by 40 tests RemoveConditionalMutator_EQUAL_IF)

Check warning on line 112 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 112 without causing a test to fail 

removed call to filter (covered by 4 tests RemoveFilterMutator)

Check warning on line 110 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to a lambda on line 110 without causing a test to fail 

removed call to filter in 2nd lambda in buildAsserterPertinentInformation (covered by 2 tests RemoveFilterMutator)

Check warning on line 139 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 139 without causing a test to fail 

removed conditional - replaced equality check with true (covered by 40 tests RemoveConditionalMutator_EQUAL_IF)

Check warning on line 154 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/PertinentInformationAllergyMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 154 without causing a test to fail 

removed conditional - replaced equality check with true (covered by 40 tests RemoveConditionalMutator_EQUAL_IF)

Check warning on line 128 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 128 without causing a test to fail 

removed conditional - replaced equality check with false (covered by 40 tests RemoveConditionalMutator_EQUAL_ELSE)

Check warning on line 71 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 71 without causing a test to fail 

removed conditional - replaced equality check with false (covered by 40 tests RemoveConditionalMutator_EQUAL_ELSE)

Check warning on line 107 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 107 without causing a test to fail 

removed conditional - replaced equality check with true (covered by 36 tests RemoveConditionalMutator_EQUAL_IF)

Check warning on line 152 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

2 different changes can be made to line 152 without causing a test to fail 

removed conditional - replaced equality check with false (covered by 41 tests RemoveConditionalMutator_EQUAL_ELSE)
replaced boolean return with true for isMedicationOrEnvironmentCategory (covered by 41 tests BooleanTrueReturnValsMutator)

Check warning on line 153 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 153 without causing a test to fail 

removed conditional - replaced equality check with true (covered by 35 tests RemoveConditionalMutator_EQUAL_IF)

Check warning on line 83 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapper.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 83 without causing a test to fail 

removed conditional - replaced equality check with true (covered by 29 tests RemoveConditionalMutator_EQUAL_IF)
View more details on GitHub Actions