Skip to content

Normalize message skeleton - #1331

Merged
ORybak5 merged 5 commits into
mainfrom
normalizing-message-skeleton
Sep 8, 2026
Merged

Normalize message skeleton#1331
ORybak5 merged 5 commits into
mainfrom
normalizing-message-skeleton

Conversation

@ORybak5

@ORybak5 ORybak5 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What

Normalize message skeleton

Why

It was deciding “whole-message skeleton” by checking only the first 100 chars for <RCMR_IN030000UK06. If the XML had leading whitespace or an XML declaration first, the message processing would needlessly fail.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Images built and published to ECR using a Build Id of PR-1368-773560f

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
  • Surviving mutants in this change: 1
  • Killed mutants in this change: 13
class surviving killed
🧟uk.nhs.adaptors.pss.translator.service.SkeletonProcessingService 1 13

See https://pitest.org

@ORybak5
ORybak5 marked this pull request as ready for review September 8, 2026 14:21
@ORybak5
ORybak5 requested a review from a team as a code owner September 8, 2026 14:21
@ORybak5
ORybak5 merged commit 239de56 into main Sep 8, 2026
19 checks passed
@ORybak5
ORybak5 deleted the normalizing-message-skeleton branch September 8, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants