Skip to content

VED-904: Add logic to uplift legacy identifiers#992

Closed
edhall-nhs wants to merge 21 commits intomasterfrom
feature/VED-904-handle-legacy-identifiers-in-batch
Closed

VED-904: Add logic to uplift legacy identifiers#992
edhall-nhs wants to merge 21 commits intomasterfrom
feature/VED-904-handle-legacy-identifiers-in-batch

Conversation

@edhall-nhs
Copy link
Copy Markdown
Contributor

@edhall-nhs edhall-nhs commented Nov 18, 2025 •
edited
Loading

Summary

❗ Breaking Change

⚠️ PLEASE DO NOT MERGE AFTER REVIEW. This must only be merged and released after the data migration as part of VED-893 has taken place

This code can also be removed once DPS has updated the relevant data on their side.

The purpose of this PR is to ensure that we can handle legacy identifier that will be sent to us from DPS via the batch process.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2025

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-904

@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 18, 2025 15:49 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 18, 2025 15:53 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 19, 2025 09:21 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 19, 2025 09:24 — with GitHub Actions Inactive
JamesW1-NHS
JamesW1-NHS reviewed Nov 19, 2025
View reviewed changes
Comment thread lambdas/recordforwarder/src/service/fhir_batch_service.py
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 19, 2025 11:16 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 19, 2025 11:20 — with GitHub Actions Inactive
JamesW1-NHS
JamesW1-NHS previously approved these changes Nov 19, 2025
View reviewed changes
Akol125
Akol125 previously approved these changes Nov 19, 2025
View reviewed changes
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 24, 2025 15:20 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 24, 2025 15:25 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 24, 2025 15:57 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox November 24, 2025 16:02 — with GitHub Actions Inactive
@edhall-nhs
Use different supplier for Failed Update scenario in e2e test
328ce9f
@edhall-nhs
Revert "Use different supplier for Failed Update scenario in e2e test"
2e24830 
This reverts commit 328ce9f.
@edhall-nhs
Revert "Revert to using RAVS_URI as default when generating csv file"
14a9ad5 
This reverts commit 4c630af.
@edhall-nhs
Revert "Update e2e tests and utils"
a968a7a 
This reverts commit 0bc7e1e.
@edhall-nhs
Revert "Fix imports in e2e test"
75cb4f1 
This reverts commit 71e9309.
@edhall-nhs
Revert "Update end-to-end tests"
19b9a2b 
This reverts commit 2294e58.
@edhall-nhs
Revert "Add comment to unit tests"
880c1f3 
This reverts commit d9d93cf.
@edhall-nhs
Revert "Add unit tests"
838c8f7 
This reverts commit 1c43086.
@edhall-nhs
Revert "Refactor to not update the resource"
19e94c6 
Change in requirements - we now want to update both identifier_pk and the identifier within the resource

This reverts commit a782fa2.
@edhall-nhs
Update comment to remove TODO
f050b90
JamesW1-NHS
JamesW1-NHS previously approved these changes Nov 26, 2025
View reviewed changes
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@edhall-nhs edhall-nhs mentioned this pull request Dec 2, 2025
Merged
8 tasks
@dlzhry2nhs
Copy link
Copy Markdown
Contributor

dlzhry2nhs commented Dec 3, 2025

Do we need to close this as superseded by #1022 or okay for now?

@edhall-nhs
Copy link
Copy Markdown
Contributor Author

edhall-nhs commented Dec 3, 2025

Yep we can close this PR and reopen if requirements change again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akol125 Akol125 Akol125 left review comments

+1 more reviewer

@JamesW1-NHS JamesW1-NHS JamesW1-NHS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edhall-nhs @dlzhry2nhs @Akol125 @JamesW1-NHS