VED-814 Resolve sonarcloud warnings on S3 bucket ownership#882
Merged
dlzhry2nhs merged 1 commit intomasterfrom Oct 7, 2025
Merged
VED-814 Resolve sonarcloud warnings on S3 bucket ownership#882dlzhry2nhs merged 1 commit intomasterfrom
dlzhry2nhs merged 1 commit intomasterfrom
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-814 |
dlzhry2nhs
force-pushed
the
feature/VED-814-sonar-cloud-warnings-s3-bucket
branch
from
5066d91 to
77c62e4
Compare
|
Akol125
reviewed
Oct 7, 2025
| Key=destination_key | ||
| Key=destination_key, | ||
| ExpectedBucketOwner=EXPECTED_BUCKET_OWNER_ACCOUNT, | ||
| ExpectedSourceBucketOwner=EXPECTED_BUCKET_OWNER_ACCOUNT |
Contributor
There was a problem hiding this comment.
just curious as to why two arguments references the same value
Contributor
Author
There was a problem hiding this comment.
It's a good question. So for any copy request (you can check boto3 - S3) you can set both the bucket owner and source bucket i.e. the bucket you are copying from.
In both cases, these are buckets that belong in our account. Hope that makes sense.
Contributor
There was a problem hiding this comment.
Hence the same account ID, makes total sense
mfjarvis
approved these changes
Oct 7, 2025
Akol125
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the outstanding security warnings we have in Sonarcloud that causes us to fail on
master/overall coverage: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&types=VULNERABILITY&severities=BLOCKER%2CCRITICAL%2CMAJOR%2CMINOR&inNewCodePeriod=true&sinceLeakPeriod=true&id=NHSDigital_immunisation-fhir-apiReviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.