Closed
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-809 |
Akol125
force-pushed
the
VED-809-destroy-pipeline
branch
from
5793abd to
efa6397
Compare
dlzhry2nhs
reviewed
Sep 30, 2025
| workflow_dispatch: | ||
| inputs: | ||
| pr_number: | ||
| description: The PR number of the environment to teardown |
Contributor
There was a problem hiding this comment.
Maybe worth include an example at the end e.g. 123. People might forget it needs to just be the number rather than pr-123.
Contributor
There was a problem hiding this comment.
The example should be 123, not pr-123
dlzhry2nhs
previously approved these changes
Sep 30, 2025
Contributor
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Looks good to me. One minor comment.
Also would be good if we could see a full destroy run and then reapply.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.