VED-1163: Elasticache Security Configurations#1451
Open
Thomas-Boyle wants to merge 3 commits intomasterfrom
Open
VED-1163: Elasticache Security Configurations#1451Thomas-Boyle wants to merge 3 commits intomasterfrom
Thomas-Boyle wants to merge 3 commits intomasterfrom
Conversation
- Added support for Redis authentication using AWS Secrets Manager. - Introduced a new `random_password` resource for generating Redis auth tokens. - Updated the `aws_elasticache_replication_group` to include authentication settings. - Modified environment variables in Lambda functions to include Redis connection details and auth token. - Enhanced the Redis client to retrieve the auth token from Secrets Manager. - Updated IAM policies to allow access to the Redis auth token. This change improves security by managing Redis credentials through AWS Secrets Manager.
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1163 |
Thomas-Boyle
added
bugfix
avshetty1980
requested changes
Apr 30, 2026
Contributor
avshetty1980
left a comment
avshetty1980
left a comment
There was a problem hiding this comment.
can we create a new replication group, repopulate it, bring over the consumers and only then remove the old cluster?
Have a dedicated Redis secret policy only to the redis consumer?
Then there are some small nits.
- Introduced a new local variable for the Redis replication group ID to enhance maintainability. - Updated CloudWatch dashboard metrics to reference the new Redis cluster ID variable. - Removed unused random password resource and Secrets Manager secret for Redis authentication. - Replaced the ElastiCache replication group resource with a cluster resource for simplified configuration. - Added a CloudFormation stack to manage Redis replication group and its authentication token securely. These changes streamline the Redis setup and improve the security of authentication management.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Added Redis authentication support using AWS Secrets Manager.
How were the changes tested
Screenshots to be provided