VED-1252: Site & Route - In case of multiple lists of valid system, it's storing only 1st list and ignores rest all lists in Imms Event table#1446
Merged
Thomas-Boyle merged 4 commits intomasterfrom May 1, 2026
Conversation
- Updated `_validate_immunization` method to validate a deep copy of the immunization input, ensuring original data remains unchanged. - Enhanced test cases to validate against the modified structure, ensuring all SNOMED codings are persisted during creation and update of immunizations.
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1252 |
Thomas-Boyle
changed the title
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
…nization event table - Introduced a new scenario in the create.feature file to validate that site and route codings are preserved in the imms event table when the first coding system is invalid. - Implemented corresponding step definitions in test_create_steps.py to create a valid JSON payload with multiple SNOMED codings and validate the response against expected outcomes. - Enhanced the test to ensure that the delta table uses the first valid SNOMED site and route coding and that all codings from the request are preserved in the imms event table.
Thomas-Boyle
dismissed stale reviews from avshetty1980 and krupasindhubaral
via
c509af3
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
|
avshetty1980
approved these changes
May 1, 2026
amarauzoma
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_validate_immunizationmethod to validate a deep copy of the immunization input, ensuring original data remains unchanged.The service now normalizes a deep copy for validation, so it still selects the first valid SNOMED coding for validation/business rules, but the original submitted coding list is preserved and saved through create/update.
Updated tests cover the scenario with:
first coding using http://snomed.info/test
second and third codings using http://snomed.info/sct
all codings retained in the persisted Immunization resource