Skip to content

Ved 318 updated automation test#1419

Merged
FimranNHS merged 3 commits intoved-318-multiple-entries-system-site-routefrom
VED-318-updated-Automation-test
Apr 16, 2026
Merged

Ved 318 updated automation test#1419
FimranNHS merged 3 commits intoved-318-multiple-entries-system-site-routefrom
VED-318-updated-Automation-test

Conversation

@FimranNHS
Copy link
Copy Markdown
Contributor

Summary

Updated the existing test to cover scenarios where multiple instances of site and route code are provided with valid system values. The request is expected to successfully processed, and the delta table should map to the first instance of the code.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

dependabot Bot and others added 3 commits April 16, 2026 09:46
…ctions-minor-patch group (#1415)

* Bump aws-actions/amazon-ecr-login

Bumps the github-actions-minor-patch group with 1 update: [aws-actions/amazon-ecr-login](https://github.com/aws-actions/amazon-ecr-login).


Updates `aws-actions/amazon-ecr-login` from 2.1.2 to 2.1.3
- [Release notes](https://github.com/aws-actions/amazon-ecr-login/releases)
- [Changelog](https://github.com/aws-actions/amazon-ecr-login/blob/main/CHANGELOG.md)
- [Commits](aws-actions/amazon-ecr-login@f2e9fc6...376925c)

---
updated-dependencies:
- dependency-name: aws-actions/amazon-ecr-login
  dependency-version: 2.1.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: empty commit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas-Boyle <thomasboyle@kainos.com>
* Bump dompurify from 3.3.2 to 3.4.0

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.3.2...3.4.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: empty commit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas-Boyle <thomasboyle@kainos.com>
@github-actions
Copy link
Copy Markdown
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-318

id: login-ecr
if: ${{ steps.decide.outputs.deployment_mode == 'build' && !steps.build-check.outputs.existing_image_digest }}
uses: aws-actions/amazon-ecr-login@f2e9fc6c2b355c1890b65e6f6f0e2ac3e6e22f78
uses: aws-actions/amazon-ecr-login@376925c9d111252e87ae59691e5a442dd100ef6a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change expected?

@sonarqubecloud
Copy link
Copy Markdown

@FimranNHS FimranNHS temporarily deployed to internal-dev-sandbox April 16, 2026 12:26 — with GitHub Actions Inactive
@FimranNHS FimranNHS temporarily deployed to internal-dev-sandbox April 16, 2026 12:26 — with GitHub Actions Inactive
@FimranNHS FimranNHS temporarily deployed to internal-dev-sandbox April 16, 2026 12:27 — with GitHub Actions Inactive
@FimranNHS FimranNHS merged commit e3aa06d into ved-318-multiple-entries-system-site-route Apr 16, 2026
19 of 20 checks passed
@FimranNHS FimranNHS deleted the VED-318-updated-Automation-test branch April 16, 2026 12:33
Thomas-Boyle added a commit that referenced this pull request Apr 22, 2026
…llowing for SITE & ROUTE but allowing for VACCINECODE and EXTENSION (#1405)

* Enhance FhirService to retain first SNOMED coding for site and route during immunization creation and update

* Ved 318 updated automation test (#1419)

* Bump aws-actions/amazon-ecr-login from 2.1.2 to 2.1.3 in the github-actions-minor-patch group (#1415)

* Bump aws-actions/amazon-ecr-login

Bumps the github-actions-minor-patch group with 1 update: [aws-actions/amazon-ecr-login](https://github.com/aws-actions/amazon-ecr-login).


Updates `aws-actions/amazon-ecr-login` from 2.1.2 to 2.1.3
- [Release notes](https://github.com/aws-actions/amazon-ecr-login/releases)
- [Changelog](https://github.com/aws-actions/amazon-ecr-login/blob/main/CHANGELOG.md)
- [Commits](aws-actions/amazon-ecr-login@f2e9fc6...376925c)

---
updated-dependencies:
- dependency-name: aws-actions/amazon-ecr-login
  dependency-version: 2.1.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: empty commit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas-Boyle <thomasboyle@kainos.com>

* Bump dompurify from 3.3.2 to 3.4.0 (#1417)

* Bump dompurify from 3.3.2 to 3.4.0

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.3.2...3.4.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: empty commit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas-Boyle <thomasboyle@kainos.com>

* updated existing test

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas-Boyle <thomasboyle@kainos.com>

* chore: empty commit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: FimranNHS <fatima.imran3@nhs.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants