VED-0000: internal-qa dependency test fixes#1352
Closed
Thomas-Boyle wants to merge 2 commits intomasterfrom
Closed
VED-0000: internal-qa dependency test fixes#1352Thomas-Boyle wants to merge 2 commits intomasterfrom
Thomas-Boyle wants to merge 2 commits intomasterfrom
Conversation
…cted MNS fields, improving data handling for SQS message validation. Updated context to include patient age and GP code. Adjusted message reading logic to allow for configurable wait times and polling limits based on action type.
Thomas-Boyle
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Error
Thomas-Boyle
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Error
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
…values gracefully. Added checks to prevent overwriting existing context attributes for GP code and patient age, and improved error handling for age calculation to avoid failures during teardown.
|
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Contributor
Author
|
Closing as Fatima raising PR with fixes for MNS tests. |
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause 1: DELETE MNS validation relied on
context.gp_codeandcontext.patient_agebeing populated in the CREATE path. When CREATE message lookup failed, teardown still validated DELETE with unset fields, producing GP mismatch / missing attribute errors.Fix 1: Added a shared populate_expected_mns_fields(context) helper and call it before both CREATE and DELETE validation. Also initialized patient_age in ScenarioContext.
Cause 2: After the requests upgrade (2.32.5 → 2.33.0) in the MNS publishing path, CREATE notification processing became slower/more variable in the environment (cold start + downstream call timing), and the existing poll budget was too tight, causing intermittent empty CREATE queue reads.
Fix 2: Increased CREATE polling tolerance (max_empty_polls from 3 to 6) to absorb the post-upgrade latency variance while keeping assertion behavior and message validation unchanged.