-
Notifications
You must be signed in to change notification settings - Fork 4
VED-1103: Refactor Batch Processor (recordprocessor) deployment to a dedicated pipeline stage #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 78 commits
07aabb1
a935585
10f08fa
d1230ac
57fcfbf
219aea8
f2f8854
0e63936
6b7f4d1
4ea668a
142de41
aad14d8
b7fe96a
e0538c4
a96ae2d
b79796b
9fabfd6
35d95ea
0ab3ae7
8820337
b0a0fe6
e05a26a
a4162b7
9a90419
94c502a
05c2220
dc8d021
fa9376e
2848c61
0f42ea0
1450b4f
fe43be3
c5b5dba
4ead26b
eefda9b
bd4e9d8
82ed767
2b081c9
f1b1c33
c810b2e
f7b9dae
479fa22
b045e15
35d67ba
6e3fe0c
4ab3b63
ea47e06
514532c
12c741f
65d9b3e
f8fa6ae
8cbf3ae
c23f017
d96cc8d
c3fcf60
fb563d5
410d3de
5f2485a
d353cb2
e8ab9fc
f22dc06
6e5e2ed
c2107d0
4a80889
61e5961
0e950e2
ccbbff7
b904694
2ce797a
b6e09b7
3f6a9ff
45375dd
5decf41
15408cf
18715a8
11e46ea
db92d2d
d16fa51
a285e4e
9238749
6173d54
2ed0248
0da81f3
413d91f
e7b3d11
feed689
e1ce138
0e43c20
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,10 @@ jobs: | |
| uses: ./.github/workflows/deploy-backend.yml | ||
| with: | ||
| apigee_environment: internal-dev | ||
| build_recordprocessor_image: true | ||
| diff_base_sha: ${{ github.event.before }} | ||
| diff_head_sha: ${{ github.sha }} | ||
| run_diff_check: true | ||
| create_mns_subscription: true | ||
| environment: dev | ||
| sub_environment: internal-dev | ||
|
|
@@ -82,6 +86,10 @@ jobs: | |
| uses: ./.github/workflows/deploy-backend.yml | ||
| with: | ||
| apigee_environment: ${{ matrix.sub_environment_name }} | ||
| recordprocessor_image_version: internal-dev-git-${{ github.sha }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know that you only update the deploy-lambda-artifact.yml file but I want to capture this incase it is missed. Higher dev environments does not consume the actual output from the producer job: The build workflow creates the recordprocessor GIT_TAG from the first 12 characters of the commit SHA. Instead they synthesize their own selector as internal-dev-git-${{ github.sha }}, which uses the full SHA. The reuse path resolves an image digest from the exact requested image version. So if internal-dev built internal-dev-git-abcdef123456, but higher environments request internal-dev-git-abcdef1234567890..., the lookup will fail. |
||
| diff_base_sha: ${{ github.event.before }} | ||
| diff_head_sha: ${{ github.sha }} | ||
| run_diff_check: true | ||
| create_mns_subscription: true | ||
| environment: dev | ||
| sub_environment: ${{ matrix.sub_environment_name }} | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.