Skip to content

VED-1088-Validate-system-URL-in-patient-identifier-resource#1272

Merged
amarauzoma merged 11 commits intomasterfrom
VED-1088-Validate-system-URL-in-patient-identifier-resource
Mar 20, 2026
Merged

VED-1088-Validate-system-URL-in-patient-identifier-resource#1272
amarauzoma merged 11 commits intomasterfrom
VED-1088-Validate-system-URL-in-patient-identifier-resource

Conversation

@amarauzoma
Copy link
Copy Markdown
Contributor

@amarauzoma amarauzoma commented Mar 5, 2026

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

Thomas-Boyle
Thomas-Boyle reviewed Mar 9, 2026
View reviewed changes
Comment thread lambdas/shared/src/common/models/fhir_immunization_pre_validators.py Outdated
Thomas-Boyle
Thomas-Boyle reviewed Mar 9, 2026
View reviewed changes
Comment thread lambdas/shared/src/common/models/fhir_immunization_pre_validators.py
avshetty1980
avshetty1980 reviewed Mar 10, 2026
View reviewed changes
Comment thread lambdas/recordforwarder/tests/controller/test_fhir_batch_controller.py Outdated
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 17, 2026 11:00 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 17, 2026 11:00 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 17, 2026 11:00 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 18, 2026 10:28 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 18, 2026 10:29 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 18, 2026 10:29 — with GitHub Actions Inactive
Thomas-Boyle
Thomas-Boyle requested changes Mar 18, 2026
View reviewed changes
Comment thread tests/e2e_automation/utilities/error_constants.py
Comment thread lambdas/shared/tests/test_common/test_immunization_pre_validator.py Outdated
Thomas-Boyle
Thomas-Boyle approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Thomas-Boyle Thomas-Boyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🚀

@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 19, 2026 09:26 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 19, 2026 09:26 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 19, 2026 09:27 — with GitHub Actions Inactive
avshetty1980
avshetty1980 approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@avshetty1980 avshetty1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks good

@amarauzoma amarauzoma enabled auto-merge (squash) March 20, 2026 10:11
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 20, 2026 10:23 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 20, 2026 10:23 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox March 20, 2026 10:24 — with GitHub Actions Inactive
@amarauzoma amarauzoma merged commit f421457 into master Mar 20, 2026
17 checks passed
@amarauzoma amarauzoma deleted the VED-1088-Validate-system-URL-in-patient-identifier-resource branch March 20, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avshetty1980 avshetty1980 avshetty1980 approved these changes

@Thomas-Boyle Thomas-Boyle Thomas-Boyle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amarauzoma @avshetty1980 @Thomas-Boyle @JamesW1-NHS