Skip to content

Commit 1c92884

Browse files
committed
add conditional for patient_detials
1 parent a8c3782 commit 1c92884

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

lambdas/mns_publisher/src/create_notification.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ def calculate_age_at_vaccination(birth_date: str, vaccination_date: str) -> int:
6464

6565
def get_practitioner_details_from_pds(nhs_number: str) -> str | None:
6666
patient_details = pds_get_patient_details(nhs_number)
67+
if not patient_details:
68+
logger.info("Unable to retrieve patient details")
69+
return None
6770

6871
general_practitioners = patient_details.get("generalPractitioner", [])
6972
if not general_practitioners or len(general_practitioners) == 0:

lambdas/mns_publisher/src/process_records.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def process_records(records: list[SQSMessage]) -> dict[str, list]:
2727
except Exception:
2828
message_id = record.get("messageId", "unknown")
2929
batch_item_failures.append({"itemIdentifier": message_id})
30+
logger.error(Exception)
3031

3132
if batch_item_failures:
3233
logger.warning(f"Batch completed with {len(batch_item_failures)} failures")

0 commit comments

Comments
 (0)