reflect new permission in e2e test

Author: motola

lambdas/mns_publisher/tests/test_create_notification.py

@@ -21,7 +21,6 @@ def _load_sample_sqs_event() -> dict:
     with open(sample_event_path, "r") as f:
         raw_event = json.load(f)
 
-    # Ensure body is a JSON string (SQS behaviour)
     if isinstance(raw_event.get("body"), dict):
         raw_event["body"] = json.dumps(raw_event["body"])
 
@@ -226,7 +225,6 @@ def test_create_mns_notification_with_update_action(self, mock_get_service_url,
 
         update_event = copy.deepcopy(self.sample_sqs_event)
 
-        # Body is a JSON string; parse -> modify -> dump back
         body = json.loads(update_event["body"])
         body["dynamodb"]["NewImage"]["Operation"]["S"] = "UPDATE"
         update_event["body"] = json.dumps(body)

lambdas/mns_publisher/tests/test_lambda_handler.py

@@ -17,7 +17,6 @@ def setUpClass(cls):
         with open(sample_event_path, "r") as f:
             raw_event = json.load(f)
 
-        # Convert body to JSON string if it's a dict
         if isinstance(raw_event.get("body"), dict):
             raw_event["body"] = json.dumps(raw_event["body"])
 
@@ -99,7 +98,6 @@ def test_process_record_success(self, mock_logger, mock_create_notification):
         mock_create_notification.return_value = self.sample_notification
         self.mock_mns_service.publish_notification.return_value = None
 
-        # Should not raise exception
         process_record(self.sample_sqs_record, self.mock_mns_service)
 
         mock_create_notification.assert_called_once_with(self.sample_sqs_record)
@@ -112,7 +110,6 @@ def test_process_record_create_notification_failure(self, mock_logger, mock_crea
         """Test handling when notification creation fails."""
         mock_create_notification.side_effect = Exception("Creation error")
 
-        # Should raise exception
         with self.assertRaises(Exception):
             process_record(self.sample_sqs_record, self.mock_mns_service)
 
@@ -125,7 +122,6 @@ def test_process_record_publish_failure(self, mock_logger, mock_create_notificat
         mock_create_notification.return_value = self.sample_notification
         self.mock_mns_service.publish_notification.side_effect = Exception("Publish error")
 
-        # Should raise exception
         with self.assertRaises(Exception):
             process_record(self.sample_sqs_record, self.mock_mns_service)
 
@@ -152,7 +148,7 @@ def test_process_records_all_success(self, mock_process_record, mock_get_mns, mo
         """Test processing multiple records with all successes."""
         mock_mns_service = Mock()
         mock_get_mns.return_value = mock_mns_service
-        mock_process_record.return_value = None  # No exception
+        mock_process_record.return_value = None
 
         record_2 = self.sample_sqs_record.copy()
         record_2["messageId"] = "different-id"
@@ -173,8 +169,8 @@ def test_process_records_partial_failure(self, mock_process_record, mock_get_mns
         mock_mns_service = Mock()
         mock_get_mns.return_value = mock_mns_service
         mock_process_record.side_effect = [
-            None,  # Success
-            Exception("Processing error"),  # Failure
+            None,
+            Exception("Processing error"),
         ]
 
         record_2 = self.sample_sqs_record.copy()
@@ -214,7 +210,7 @@ def test_process_records_mns_service_created_once(self, mock_process_record, moc
 
         process_records(records)
 
-        mock_get_mns.assert_called_once()  # Only created once
+        mock_get_mns.assert_called_once()
 
 
 class TestLambdaHandler(unittest.TestCase):