Feature/rb kt eli 207 configure provision dynamodb v2#66
Merged
Karthikeyannhs merged 20 commits intomainfrom May 1, 2025
Merged
Feature/rb kt eli 207 configure provision dynamodb v2#66Karthikeyannhs merged 20 commits intomainfrom
Karthikeyannhs merged 20 commits intomainfrom
Conversation
eddalmond1
reviewed
Apr 29, 2025
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Added deets about DPS accounts and some other minor comments
robbailiff2
changed the base branch from
feature/eja-eli-202-add-developer-roles
to
main
…es_btwn_workspaces default workspace is the owner of iam policies and roles
eddalmond1
reviewed
May 1, 2025
eddalmond1
reviewed
May 1, 2025
Collaborator
|
Happy with the changes, made a couple of comments. Worth pulling in latest main and seeing if the Github OIDC connection is still happy, and updating the README to take into account the changes made regarding the 'default' vs other workspaces. |
eddalmond1
previously approved these changes
May 1, 2025
eddalmond1
approved these changes
May 1, 2025
eddalmond1
deleted the
feature/rb-kt-eli-207-configure-provision-dynamodb_v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.