eli-731 adding missing permissions that the regression test role needs#658
Merged
eddalmond1 merged 1 commit intomainfrom Apr 27, 2026
Conversation
eddalmond1
commented
Apr 27, 2026
| "secretsmanager:DescribeSecret" | ||
| ] | ||
| "secretsmanager:DescribeSecret", | ||
| "secretsmanager:UpdateSecretVersionStage", |
Collaborator
Author
There was a problem hiding this comment.
UpdateSecretVersionStage and PutSecretValue are used by the regression tests to test hashing/secrets
eddalmond1
commented
Apr 27, 2026
| "dynamodb:Scan", | ||
| "dynamodb:UpdateItem", | ||
| "dynamodb:DeleteItem", | ||
| "dynamodb:BatchWriteItem", |
Collaborator
Author
There was a problem hiding this comment.
Regression tests use BatchWrite to write test data
eddalmond1
commented
Apr 27, 2026
| variable = "token.actions.githubusercontent.com:job_workflow_ref" | ||
| values = [ | ||
| "${var.github_org}/${var.regression_repo}/.github/workflows/regression_tests.yml@*" | ||
| "repo:${var.github_org}/${var.regression_repo}:*", |
Collaborator
Author
There was a problem hiding this comment.
We need to allow the role to be assumed by workflows in both the main repo (this one) and the regression test repo
eddalmond1
commented
Apr 27, 2026
| # Environment-specific actions | ||
| dynamic "statement" { | ||
| for_each = var.environment == "preprod" ? [1] : [] | ||
| for_each = contains(["dev", "test", "preprod"], var.environment) ? [1] : [] |
Collaborator
Author
There was a problem hiding this comment.
We need dynamoDB permissions for the regression test role to be within the permissions boundary for all pre-live environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding additional permissions needed for the regression test role
Context
So that tests can run automatically
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.