Skip to content

eli-759 adding secret inheritence#652

Merged
eddalmond1 merged 3 commits intomainfrom
feature/eja-eli-759-removing-reliance-on-PAT-for-regression-tests
Apr 24, 2026
Merged

eli-759 adding secret inheritence#652
eddalmond1 merged 3 commits intomainfrom
feature/eja-eli-759-removing-reliance-on-PAT-for-regression-tests

Conversation

@eddalmond1
Copy link
Copy Markdown
Collaborator

... bugfix part 2 - adding implicit passing of account ids to the regression test workflow

@eddalmond1 eddalmond1 requested a review from a team as a code owner April 23, 2026 14:01
@TOEL2
Copy link
Copy Markdown
Contributor

TOEL2 commented Apr 24, 2026

Will this also fix this preprod bug? It looks like something different.
image

link to the run: https://github.com/NHSDigital/eligibility-signposting-api/actions/runs/24878284931

[Invalid workflow file: .github/workflows/cicd-4-preprod-deploy.yaml#L268](https://github.com/NHSDigital/eligibility-signposting-api/actions/runs/24878284931/workflow) The workflow is not valid. NHSDigital/eligibility-signposting-api/.github/workflows/base-deploy.yml@df563795350f2ab87e14319cad0bcee72303cac6 (Line: 268, Col: 3): Error calling workflow 'NHSDigital/eligibility-signposting-api/.github/workflows/regression-tests.yml@df563795350f2ab87e14319cad0bcee72303cac6'. The nested job 'regression-tests' is requesting 'issues: write, pull-requests: write', but is only allowed 'issues: none, pull-requests: none'.

@eddalmond1 eddalmond1 merged commit 924b7af into main Apr 24, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants