Skip to content

eja - adding permissions for the called workflow to inherit#651

Merged
eddalmond1 merged 3 commits intomainfrom
feature/eja-eli-759-removing-reliance-on-PAT-for-regression-tests
Apr 23, 2026
Merged

eja - adding permissions for the called workflow to inherit#651
eddalmond1 merged 3 commits intomainfrom
feature/eja-eli-759-removing-reliance-on-PAT-for-regression-tests

Conversation

@eddalmond1
Copy link
Copy Markdown
Collaborator

@eddalmond1 eddalmond1 commented Apr 23, 2026

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the regression test GitHub Actions reusable-workflow caller to explicitly grant additional GITHUB_TOKEN permissions so the downstream called workflow can inherit them.

Changes:

  • Added explicit job-level permissions to the regression-tests reusable workflow caller.
  • Granted id-token: write, issues: write, and pull-requests: write to the job invoking the external reusable workflow.

Comment thread .github/workflows/regression-tests.yml
Comment thread .github/workflows/regression-tests.yml
Copy link
Copy Markdown
Contributor

@ayeshalshukri1-nhs ayeshalshukri1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddalmond1 eddalmond1 merged commit c5312b4 into main Apr 23, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants