Skip to content

Eli 782/add constant and field for configurable status text#631

Merged
oneeb-nhs merged 4 commits intomainfrom
ELI-782/add_constant_and_field_for_configurable_status_text
Apr 8, 2026
Merged

Eli 782/add constant and field for configurable status text#631
oneeb-nhs merged 4 commits intomainfrom
ELI-782/add_constant_and_field_for_configurable_status_text

Conversation

@oneeb-nhs
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@oneeb-nhs oneeb-nhs requested a review from a team as a code owner April 8, 2026 11:12
Comment thread tests/unit/model/test_status.py
Comment thread tests/unit/config/test_config.py
Copy link
Copy Markdown
Collaborator

@eddalmond1 eddalmond1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth amending test_matched_action_detail_existing_constructor_still_works_with_three_args and test_matched_action_detail_existing_constructor_works_with_four_args to use hamcrest, the other new tests are simpler, but would be quick to amend them too

@oneeb-nhs oneeb-nhs requested a review from eddalmond1 April 8, 2026 15:14
@oneeb-nhs oneeb-nhs merged commit 8581406 into main Apr 8, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants