Eli 704/adding cloudwatch metric filter cloudtrail#613
Merged
Conversation
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
eddalmond1
reviewed
Mar 23, 2026
Collaborator
|
Nothing to do for this comment - but noting that cloudtrail works on the AWS Control Plane, and the things it interacts with (s3, Cloudwatch logs and KMS) all have existing VPC endpoints in our setup, so looking good from a security perspective |
robbailiff2
force-pushed
the
ELI-704/adding-cloudwatch-metric-filter-cloudtrail
branch
from
0da5528 to
b99dda3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
oneeb-nhs
force-pushed
the
ELI-704/adding-cloudwatch-metric-filter-cloudtrail
branch
from
e049471 to
c2081c4
Compare
eddalmond1
reviewed
Mar 27, 2026
eddalmond1
previously requested changes
Mar 27, 2026
Collaborator
eddalmond1
left a comment
eddalmond1
left a comment
There was a problem hiding this comment.
Couple of comments, but mostly there!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.