Skip to content

cohort grouping & magic cohorts - extensive coverage#145

Merged
Karthikeyannhs merged 11 commits intomainfrom
test/more_test_for_cohort_grouping
Jun 12, 2025
Merged

cohort grouping & magic cohorts - extensive coverage#145
Karthikeyannhs merged 11 commits intomainfrom
test/more_test_for_cohort_grouping

Conversation

@Karthikeyannhs
Copy link
Copy Markdown
Contributor

@Karthikeyannhs Karthikeyannhs commented Jun 10, 2025

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch 4 times, most recently from 6e6fbb3 to 15044e6 Compare June 10, 2025 22:11
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch from 15044e6 to 9c321dc Compare June 10, 2025 22:19
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch 2 times, most recently from 62d5f3a to cd72ee9 Compare June 11, 2025 02:26
Comment thread src/eligibility_signposting_api/services/calculators/eligibility_calculator.py Outdated
@Karthikeyannhs Karthikeyannhs marked this pull request as draft June 11, 2025 09:05
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch from cd72ee9 to bd41072 Compare June 11, 2025 09:07
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch from ed6f775 to b0cdc81 Compare June 11, 2025 14:58
@Karthikeyannhs Karthikeyannhs marked this pull request as ready for review June 11, 2025 16:23
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch 3 times, most recently from f6fccd1 to 8e9e8de Compare June 12, 2025 12:32
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch from 8e9e8de to bc1fab8 Compare June 12, 2025 12:42
@Karthikeyannhs Karthikeyannhs force-pushed the test/more_test_for_cohort_grouping branch from b383928 to 17cfb8e Compare June 12, 2025 14:04
TOEL2
TOEL2 previously approved these changes Jun 12, 2025
Copy link
Copy Markdown
Contributor

@TOEL2 TOEL2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have walked through with the dev team and looks good

Copy link
Copy Markdown
Contributor

@TOEL2 TOEL2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved linting change

@Karthikeyannhs Karthikeyannhs merged commit af8fef9 into main Jun 12, 2025
21 checks passed
@Karthikeyannhs Karthikeyannhs deleted the test/more_test_for_cohort_grouping branch June 13, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants