Skip to content

Update: [AEA-6581] - make assist me regression role available to assist me repo #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 2 commits into from
Apr 30, 2026
+8 −4
Merged

Update: [AEA-6581] - make assist me regression role available to assist me repo #2270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab68d0
chore: make assist me regression role available to assist me repo
bencegadanyi1-nhs Apr 29, 2026
14b00ea
Merge branch 'main' into AEA-6581-regression-filter-update
anthony-nhs Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion environmentSettings/dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@
"NONE"
],
"AssistMeRegressionTestClaimFilters": [
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*"
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*",
"repo:NHSDigital/eps-assist-me:*"
],
Comment on lines 109 to 112
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the Assist Me regression role should be available to the eps-assist-me repo, but this change is only applied to dev/ref/qa/int. environmentSettings/prod.json still has AssistMeRegressionTestClaimFilters limited to the regression-tests repo, so eps-assist-me still won't be able to assume the role in prod. If prod access is intentionally excluded, consider updating the PR description to reflect that; otherwise, the prod environment settings likely need the same addition.

Copilot uses AI. Check for mistakes.
"AssistMeDocumentSyncClaimFilters": [
"NONE"
Expand Down
3 changes: 2 additions & 1 deletion environmentSettings/int.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@
"NONE"
],
"AssistMeRegressionTestClaimFilters": [
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*"
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*",
"repo:NHSDigital/eps-assist-me:*"
Comment on lines +70 to +71
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In int, most OIDC sub claim filters for sensitive roles (e.g. DeploySubjectClaimFilters) are scoped to a protected GitHub Environment (...:environment:int), but AssistMeRegressionTestClaimFilters uses the broad repo:...:* pattern. Adding repo:NHSDigital/eps-assist-me:* means any workflow ref (including non-environment contexts) in that repo could assume the regression role. If the intent is to restrict this to the int environment, consider using an environment-scoped subject claim here (and aligning the existing regression-tests entry similarly).

Suggested change
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*",
"repo:NHSDigital/eps-assist-me:*"
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:environment:int",
"repo:NHSDigital/eps-assist-me:environment:int"

Copilot uses AI. Check for mistakes.
],
"AssistMeDocumentSyncClaimFilters": [
"repo:NHSDigital/eps-assist-me:*"
Expand Down
3 changes: 2 additions & 1 deletion environmentSettings/qa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
"NONE"
],
"AssistMeRegressionTestClaimFilters": [
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*"
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*",
"repo:NHSDigital/eps-assist-me:*"
],
"AssistMeDocumentSyncClaimFilters": [
"NONE"
Expand Down
3 changes: 2 additions & 1 deletion environmentSettings/ref.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
"NONE"
],
"AssistMeRegressionTestClaimFilters": [
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*"
"repo:NHSDigital/electronic-prescription-service-api-regression-tests:*",
"repo:NHSDigital/eps-assist-me:*"
],
"AssistMeDocumentSyncClaimFilters": [
"NONE"
Expand Down