Skip to content

Fix: [AEA-0000] - limit proxygen error logging to not log full request body #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Sep 30, 2025
Merged

Fix: [AEA-0000] - limit proxygen error logging to not log full request body #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/proxygen/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function proxygenErrorHandler(error: unknown, logger: Logger) {
stack: error.stack,
message: error.message,
config: {
data: error.config?.data,
data: (error.config?.data ?? "").toString().slice(0, 255), // limit to first 255 chars as it may be full spec
headers: error.config?.headers,
method: error.config?.method,
url: error.config?.url
Expand Down
4 changes: 2 additions & 2 deletions packages/proxygen/tests/proxygenInstanceDelete.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ describe("Unit test for proxygenInstanceDelete", function () {
status: 500,
message: "Request failed with status code 500",
config: {
data: undefined,
data: "",
headers: expect.objectContaining({
Accept: "application/json, text/plain, */*",
"Content-Type": "application/json",
Expand Down Expand Up @@ -142,7 +142,7 @@ describe("Unit test for proxygenInstanceDelete", function () {
axiosError: expect.objectContaining({
message: "Something awful happened",
config: {
data: undefined,
data: "",
headers: expect.objectContaining({
Accept: "application/json, text/plain, */*",
"Content-Type": "application/json",
Expand Down
4 changes: 2 additions & 2 deletions packages/proxygen/tests/proxygenInstanceGet.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe("Unit test for proxygenInstanceGet", function () {
status: 500,
message: "Request failed with status code 500",
config: {
data: undefined,
data: "",
headers: expect.objectContaining({
Accept: "application/json, text/plain, */*",
"Content-Type": "application/json",
Expand Down Expand Up @@ -139,7 +139,7 @@ describe("Unit test for proxygenInstanceGet", function () {
axiosError: expect.objectContaining({
message: "Something awful happened",
config: {
data: undefined,
data: "",
headers: expect.objectContaining({
Accept: "application/json, text/plain, */*",
"Content-Type": "application/json",
Expand Down
Loading