Closed
Conversation
(not sure why this wasn't failing before)
This will be used on non-production environments so that non-team members don't confuse them with live services. Later, we'll add a personas page for force-logging in users with different roles/permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds middleware that authenticates using HTTP basic authentication, configured by environment variables.
This is not integrated with django.contrib.auth - so
request.user.is_authenticatedis still False after submitting valid credentials.The plan is to introduce a separate page that will allow you to choose the persona you want to log in as. This will only be available on non-production environments.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10297
Review notes
For context - here is my earlier approach, which logged in a user if the basic auth was successful.