Fix upgrade to authlib 1.7.0#1399
Open
malcolmbaig wants to merge 2 commits intomainfrom
Open
Conversation
authlib 1.7.0 removed `DjangoOAuth2App.create_load_key()` as part of its internal migration to joserfc. Re-implement the deleted method as a local helper `_create_cis2_key_loader`, preserving the JWKS force-refresh on kid miss to handle CIS2 key rotation without a process restart. This commit also adds unit tests for the back-channel logout view.
malcolmbaig
force-pushed
the
mb-authlib-debug--20260429--fix
branch
from
67cbb18 to
c3f0011
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
authlib 1.7.0 removed
DjangoOAuth2App.create_load_key()as part ofits internal migration to joserfc. Re-implement the deleted method as a
local helper
_create_cis2_key_loader, preserving the JWKS force-refreshon kid miss to handle CIS2 key rotation without a process restart.
This commit also adds unit tests for the back-channel logout view.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12826
Review notes
Review checklist
/api/v1/), confirm whether it is a breaking change — if so, a new major version (/api/v2/) is required (see ADR-006)