Skip to content

fix: create exception returning the wrong HTTP code#846

Merged
will-larkin-nhs merged 2 commits intomainfrom
create-exception-fix
Mar 25, 2025
Merged

fix: create exception returning the wrong HTTP code#846
will-larkin-nhs merged 2 commits intomainfrom
create-exception-fix

Conversation

@will-larkin-nhs
Copy link
Copy Markdown
Contributor

Description

  • changed create exception to return OK instead of CREATED

Context

In a previous PR, create exception was changed to return CREATED to fix a sonarqube issue, but the exception handler client expects an OK response, so this was causing the create exception request to be logged as a failure

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@will-larkin-nhs will-larkin-nhs added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit cea7897 Mar 25, 2025
27 checks passed
@will-larkin-nhs will-larkin-nhs deleted the create-exception-fix branch March 25, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants