Skip to content

fix: change rule to use IsNullOrEmpty#805

Merged
will-larkin-nhs merged 1 commit intomainfrom
DTOSS-7811-transform-rule-3-fix
Mar 24, 2025
Merged

fix: change rule to use IsNullOrEmpty#805
will-larkin-nhs merged 1 commit intomainfrom
DTOSS-7811-transform-rule-3-fix

Conversation

@will-larkin-nhs
Copy link
Copy Markdown
Contributor

Description

Changed transform rule 3 date of death not null with RFR != DEA to use string.IsNullOrEmpty()

Context

The transformation rule was triggering for every participant because the rule used != null instead of !string.IsNullOrEmpty
DTOSS-7811

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@stephhou stephhou added the bug Something isn't working label Mar 13, 2025
@will-larkin-nhs will-larkin-nhs added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit 4c5475e Mar 24, 2025
@will-larkin-nhs will-larkin-nhs deleted the DTOSS-7811-transform-rule-3-fix branch March 24, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants