Skip to content

refactor: DTOSS-7517 - Continued adding config classes for the rest of the functions#793

Merged
SamAinsworth-NHS merged 52 commits intomainfrom
continued-config-classes
Mar 20, 2025
Merged

refactor: DTOSS-7517 - Continued adding config classes for the rest of the functions#793
SamAinsworth-NHS merged 52 commits intomainfrom
continued-config-classes

Conversation

@SamAinsworth-NHS
Copy link
Copy Markdown
Contributor

@SamAinsworth-NHS SamAinsworth-NHS commented Mar 10, 2025

Description

Added a new config class to each function to replace all environment variable direct usage in Program.cs.

Details can be found in this spreadsheet

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-7517

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@SamAinsworth-NHS SamAinsworth-NHS added the DO NOT MERGE Do not merge this branch label Mar 10, 2025
@stephhou stephhou added the config Changes to the config for platform improvement label Mar 10, 2025
@SamAinsworth-NHS SamAinsworth-NHS changed the title refactor: WIP - Continued adding config classes for the rest of the functions refactor: Continued adding config classes for the rest of the functions Mar 11, 2025
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as ready for review March 11, 2025 13:38
@SamAinsworth-NHS SamAinsworth-NHS removed the DO NOT MERGE Do not merge this branch label Mar 11, 2025
andrewmorris43
andrewmorris43 previously approved these changes Mar 12, 2025
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as draft March 12, 2025 09:29
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as draft March 12, 2025 16:57
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as ready for review March 13, 2025 13:00
@SamAinsworth-NHS SamAinsworth-NHS changed the title refactor: Continued adding config classes for the rest of the functions refactor: DTOSS-7517 - Continued adding config classes for the rest of the functions Mar 13, 2025
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as draft March 18, 2025 09:18
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as ready for review March 20, 2025 13:42
@SamAinsworth-NHS SamAinsworth-NHS added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 4869b6c Mar 20, 2025
49 checks passed
@SamAinsworth-NHS SamAinsworth-NHS deleted the continued-config-classes branch March 20, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Changes to the config for platform improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants