fix: Implemented TODO fixes

application/CohortManager/src/Functions/Shared/Data/Database/CreateCohortDistributionData.cs

@@ -39,11 +39,12 @@ public async Task<List<CohortDistributionParticipantDto>> GetUnextractedCohortDi
         }
         else
         {
-            var participantsList = await _cohortDistributionDataServiceClient.GetByFilter(x => x.IsExtracted.Equals(0) && x.RequestId == Guid.Empty);
-            participantsToBeExtracted = participantsList.OrderBy(x => x.RecordUpdateDateTime ?? x.RecordInsertDateTime).Take(rowCount).ToList();
+
+            participantsToBeExtracted = (await _cohortDistributionDataServiceClient.GetByFilter(x => x.IsExtracted.Equals(0) && x.RequestId == Guid.Empty,
+            x => x.RecordUpdateDateTime ?? x.RecordInsertDateTime ?? DateTime.MinValue,rowCount)).ToList();
+
         }
 
-        //TODO do this filtering on the data services
         var CohortDistributionParticipantList = participantsToBeExtracted.Select(x => new CohortDistributionParticipant(x)).ToList();
 
 

application/CohortManager/src/Functions/Shared/DataServices.Client/DataServiceClient.cs

@@ -48,6 +48,15 @@ public async Task<IEnumerable<TEntity>> GetByFilter(Expression<Func<TEntity, boo
         return result;
     }
 
+    public async Task<IEnumerable<TEntity>> GetByFilter(Expression<Func<TEntity, bool>> predicate, Expression<Func<TEntity, object>> orderBy, int take)
+    {
+
+        var result = await GetByFilter(predicate);
+        var orderByFunction = orderBy.Compile();
+        return result.OrderBy(orderByFunction).Take(take).ToList();
+
+    }
+
     public virtual async Task<TEntity> GetSingle(string id)
     {
         try

application/CohortManager/src/Functions/Shared/DataServices.Client/DataServiceStaticCachedClient.cs

@@ -77,6 +77,18 @@ public async Task<IEnumerable<TEntity>> GetByFilter(Expression<Func<TEntity, boo
         return _data.Where(predicateFunction).ToList();
     }
 
+    public async Task<IEnumerable<TEntity>> GetByFilter(Expression<Func<TEntity, bool>> predicate, Expression<Func<TEntity, object>> orderBy, int take)
+    {
+
+        _logger.LogInformation("Getting By Filter ordered from static data service {EntityName}", typeof(TEntity).FullName);
+        await Task.CompletedTask;
+
+        var predicateFunction = predicate.Compile();
+        var orderByFunction = orderBy.Compile();
+        return _data.Where(predicateFunction).OrderBy(orderByFunction).Take(take).ToList();
+
+    }
+
     public Task<bool> Add(TEntity entity)
     {
         throw new NotImplementedException();

application/CohortManager/src/Functions/Shared/DataServices.Client/IDataServiceClient.cs

@@ -30,6 +30,13 @@ public interface IDataServiceClient<TEntity>
     /// <summary>
     /// Adds a given records to the database
     /// </summary>
+    /// <param name="predicate">linq query defining the filter on the table</param>
+    /// <param name="orderBy">query defining the order</param>
+    /// <param name="take">number of records to take from the filtered result</param>
+    Task<IEnumerable<TEntity>> GetByFilter(Expression<Func<TEntity, bool>> predicate, Expression<Func<TEntity, object>> orderBy, int take);
+    /// <summary>
+    /// Adds a given records to the database
+    /// </summary>
     /// <param name="entity">object of type TEntity to be inserted in the database</param>
     /// <returns>a boolean representing if the record was inserted successfully</returns>
     Task<bool> Add(TEntity entity);

application/CohortManager/src/Functions/Shared/Common/Utilities/ReflectionUtilities.cs → application/CohortManager/src/Functions/Shared/Utilities/ReflectionUtilities.cs

@@ -3,7 +3,6 @@
 using System.ComponentModel.DataAnnotations;
 using System.Reflection;
 
-// TODO: move to Shared/Utilities
 public static class ReflectionUtilities
 {
     /// <summary>
@@ -14,14 +13,14 @@
     public static PropertyInfo GetKey<TEntity>() where TEntity : class
     {
         var type = typeof(TEntity);
         return type.GetProperties().FirstOrDefault(p =>
             p.CustomAttributes.Any(attr => attr.AttributeType == typeof(KeyAttribute)));
     }
 
 
     public static Type GetPropertyType(Type type, string property)
     {
         return type.GetProperty(property).PropertyType;
     }
 
     public static bool PropertyExists(Type type, string property) =>

tests/UnitTests/CohortDistributionTests/CohortDistributionDataTests/AddCohortDistributionTests.cs

@@ -30,6 +30,10 @@ public void Setup()
             .Setup(x => x.GetByFilter(It.IsAny<Expression<Func<CohortDistribution, bool>>>()))
             .ReturnsAsync((Expression<Func<CohortDistribution, bool>> filter) =>
                 _participantList.Where(filter.Compile()).ToList());
+        _cohortDistributionDataServiceClient
+            .Setup(x => x.GetByFilter(It.IsAny<Expression<Func<CohortDistribution, bool>>>(), It.IsAny<Expression<Func<CohortDistribution, object>>>(), It.IsAny<int>()))
+            .ReturnsAsync((Expression<Func<CohortDistribution, bool>> filter, Expression<Func<CohortDistribution, object>> orderBy, int take) =>
+                _participantList.Where(filter.Compile()).OrderBy(orderBy.Compile()).Take(take).ToList());
 
         _cohortDistributionDataServiceClient
             .Setup(x => x.GetSingle(It.IsAny<string>()))