fix: use the correct value name and data type#1618
Merged
chrimesdev merged 6 commits intomainfrom Sep 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the data structure and property naming for the UpdateExceptionServiceNowId endpoint, correcting field names and data types to ensure proper API functionality.
- Renamed
ServiceNowNumbertoServiceNowIdacross the codebase for consistency - Changed
ExceptionIdfrom string to number type to match expected data format - Enhanced error handling and validation logic in the API route
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| updateExceptions.ts | Updated request body to use correct field names and removed unnecessary string conversion |
| updateExceptions.test.ts | Updated test expectations to match new field names and data types |
| route.ts | Enhanced type definitions, validation logic, and error handling for the API endpoint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chrimesdev
force-pushed
the
fix/use-the-correct-values
branch
from
6cf0d98 to
af4d129
Compare
chrimesdev
force-pushed
the
fix/use-the-correct-values
branch
2 times, most recently
from
129d877 to
ab1b313
Compare
Warren-Pitterson
previously approved these changes
Sep 9, 2025
chrimesdev
force-pushed
the
fix/use-the-correct-values
branch
from
13792f8 to
a05e088
Compare
Warren-Pitterson
approved these changes
Sep 9, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request uses the correct value name and data type for the
UpdateExceptionServiceNowIdendpointContext
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.