Skip to content

test: Fixed validateServiceNowRequestWithMockServer in playwright tests by adding a wait#1602

Merged
alex-clayton-1 merged 1 commit intomainfrom
test/fix-snow-request-validation
Sep 4, 2025
Merged

test: Fixed validateServiceNowRequestWithMockServer in playwright tests by adding a wait#1602
alex-clayton-1 merged 1 commit intomainfrom
test/fix-snow-request-validation

Conversation

@alex-clayton-1
Copy link
Copy Markdown
Contributor

@alex-clayton-1 alex-clayton-1 commented Sep 4, 2025

Description

  • Added a 5 second wait
  • Moved WireMock cleanup to run before tests to align with database cleanup

Context

Playwright tests were failing because they would run before the test records were fully processed.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

Unit Test Results

✔️ Tests 777 / 777 - passed in 62.2s
📝 Coverage 56.94%
📏 4285 / 7411 lines covered 🌿 1055 / 1968 branches covered
🔍 click here for more details

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 4, 2025

@alex-clayton-1 alex-clayton-1 added this pull request to the merge queue Sep 4, 2025
Merged via the queue into main with commit 7195f86 Sep 4, 2025
65 checks passed
@alex-clayton-1 alex-clayton-1 deleted the test/fix-snow-request-validation branch September 4, 2025 16:47
stephhou pushed a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants