fix: ensure the ServiceNow case ID matches the expected pattern#1590
Merged
chrimesdev merged 3 commits intomainfrom Sep 3, 2025
Merged
fix: ensure the ServiceNow case ID matches the expected pattern#1590chrimesdev merged 3 commits intomainfrom
chrimesdev merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the validation pattern for ServiceNow case IDs to enforce a more specific format requirement. The validation now requires case IDs to start with exactly two letters followed by at least seven digits, replacing the previous more permissive validation that only required 9+ alphanumeric characters.
- Updated validation schema to enforce the pattern of two letters followed by at least seven digits
- Simplified validation logic by consolidating multiple refinement checks into a single regex pattern
- Updated all corresponding test cases and error messages to reflect the new format requirement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| formValidationSchemas.ts | Updated ServiceNow case ID validation to require two letters followed by at least seven digits |
| formValidationSchemas.test.ts | Updated test cases and expected error messages to match the new validation pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chrimesdev
force-pushed
the
fix/form-validation
branch
from
f1da52a to
aed1135
Compare
chrimesdev
force-pushed
the
fix/form-validation
branch
from
aed1135 to
0dd9a00
Compare
chrimesdev
force-pushed
the
fix/form-validation
branch
from
0dd9a00 to
d1377a3
Compare
|
Rabo2024
approved these changes
Sep 3, 2025
stephhou
pushed a commit
that referenced
this pull request
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the validation pattern for ServiceNow case IDs to enforce a more specific format requirement. The validation now requires case IDs to start with exactly two letters followed by at least seven digits.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.