Skip to content

fix: DTOSS-10762 CD Pipeline conditions improvement#1587

Merged
patrickmoore-nc merged 4 commits intomainfrom
fix/DTOSS-10762-pipeline-conditional-logic3
Sep 3, 2025
Merged

fix: DTOSS-10762 CD Pipeline conditions improvement#1587
patrickmoore-nc merged 4 commits intomainfrom
fix/DTOSS-10762-pipeline-conditional-logic3

Conversation

@patrickmoore-nc
Copy link
Copy Markdown
Contributor

@patrickmoore-nc patrickmoore-nc commented Sep 3, 2025

Description

  • CD pipeline improvement: don't launch db_changes_stage or restart_functions_stage unless Terraform Apply or the ACR re-tagging ran successfully. Prevents unexpected restarts when simply running a Terraform Plan.
  • Other conditional logic simplifications.
  • For clarity, added conditional displayname for the terraform_deploy stage, so that it's labelled Terraform Plan if no apply is selected when initiating the pipeline.

Testing

Tested in branch:
https://dev.azure.com/nhse-dtos/dtos-cohort-manager/_build/results?buildId=26639&view=results

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2025

Unit Test Results

✔️ Tests 777 / 777 - passed in 63.2s
📝 Coverage 56.95%
📏 4288 / 7414 lines covered 🌿 1055 / 1968 branches covered
🔍 click here for more details

✏️ updated for commit d6a7785

@patrickmoore-nc patrickmoore-nc marked this pull request as ready for review September 3, 2025 11:21
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@MacMur85 MacMur85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@patrickmoore-nc patrickmoore-nc added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit f598e38 Sep 3, 2025
67 checks passed
@patrickmoore-nc patrickmoore-nc deleted the fix/DTOSS-10762-pipeline-conditional-logic3 branch September 3, 2025 11:29
stephhou pushed a commit that referenced this pull request Sep 5, 2025
* fix: CD Pipeline conditions improvement

* Update cd-infrastructure-core-common.yaml

* Update cd-infrastructure-core-common.yaml

* Update cd-infrastructure-core-common.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants