Skip to content

fix: add the new rules to the ruleMappings to match spreadsheet#1586

Merged
chrimesdev merged 5 commits intomainfrom
fix/new-rules
Sep 3, 2025
Merged

fix: add the new rules to the ruleMappings to match spreadsheet#1586
chrimesdev merged 5 commits intomainfrom
fix/new-rules

Conversation

@chrimesdev
Copy link
Copy Markdown
Member

@chrimesdev chrimesdev commented Sep 3, 2025

Description

Add new rules from the Spreadsheet to the Rules mapping

https://www.youtube.com/watch?v=k2qgadSvNyU

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@chrimesdev chrimesdev enabled auto-merge September 3, 2025 09:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2025

Unit Test Results

✔️ Tests 777 / 777 - passed in 60.2s
📝 Coverage 56.95%
📏 4288 / 7414 lines covered 🌿 1055 / 1968 branches covered
🔍 click here for more details

✏️ updated for commit d201c70

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 3, 2025

@chrimesdev chrimesdev added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 8c39995 Sep 3, 2025
64 checks passed
@chrimesdev chrimesdev deleted the fix/new-rules branch September 3, 2025 10:18
stephhou pushed a commit that referenced this pull request Sep 5, 2025
* fix: add the new rules to the ruleMappings to match spreadsheet

* fix: add exceptions for the new rules

* fix: fix broken test by removing old id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants