fix: rule 35 executing for amends with no previous add records#1557
Merged
will-larkin-nhs merged 3 commits intomainfrom Sep 8, 2025
Merged
fix: rule 35 executing for amends with no previous add records#1557will-larkin-nhs merged 3 commits intomainfrom
will-larkin-nhs merged 3 commits intomainfrom
Conversation
Joseph2910
previously approved these changes
Aug 29, 2025
chrimesdev
previously approved these changes
Aug 29, 2025
7ecfc66
chrimesdev
approved these changes
Sep 8, 2025
|
Joseph2910
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
fixes an issue where rule 35 is executing for amends that do not have a previous record in the cohort distribution table
Context
the previous null check for the rule was checking if the participant ID was null but it is set to 0 when we create a blank record if there isn't a previous one
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.