Skip to content

fix: rule 35 executing for amends with no previous add records#1557

Merged
will-larkin-nhs merged 3 commits intomainfrom
fix/rule-35-issue
Sep 8, 2025
Merged

fix: rule 35 executing for amends with no previous add records#1557
will-larkin-nhs merged 3 commits intomainfrom
fix/rule-35-issue

Conversation

@will-larkin-nhs
Copy link
Copy Markdown
Contributor

Description

fixes an issue where rule 35 is executing for amends that do not have a previous record in the cohort distribution table

Context

the previous null check for the rule was checking if the participant ID was null but it is set to 0 when we create a blank record if there isn't a previous one

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Joseph2910
Joseph2910 previously approved these changes Aug 29, 2025
chrimesdev
chrimesdev previously approved these changes Aug 29, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2025

Unit Test Results

✔️ Tests 825 / 825 - passed in 64.2s
📝 Coverage 58.07%
📏 4489 / 7621 lines covered 🌿 1087 / 1982 branches covered
🔍 click here for more details

✏️ updated for commit fb5bc75

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 8, 2025

@will-larkin-nhs will-larkin-nhs added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit 2aebbd9 Sep 8, 2025
65 checks passed
@will-larkin-nhs will-larkin-nhs deleted the fix/rule-35-issue branch September 8, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants