Skip to content

fix: fix broken tests, configuration and add unit tests#1556

Merged
chrimesdev merged 28 commits intomainfrom
tests/fix-tests
Sep 9, 2025
Merged

fix: fix broken tests, configuration and add unit tests#1556
chrimesdev merged 28 commits intomainfrom
tests/fix-tests

Conversation

@chrimesdev
Copy link
Copy Markdown
Member

@chrimesdev chrimesdev commented Aug 28, 2025

Description

This PR fixes broken test infrastructure and improves test configuration for the Cohort Manager application by migrating from legacy test patterns to a modern Playwright BDD framework.

  • Refactored existing feature tests from legacy step definitions to modern Playwright BDD approach
  • Updated test configuration to use HTTP instead of HTTPS and simplified browser testing
  • Added unit tests to the CI workflow and consolidated test commands

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@chrimesdev chrimesdev requested a review from Copilot August 28, 2025 19:31

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 28, 2025

Unit Test Results

✔️ Tests 824 / 824 - passed in 65.9s
📝 Coverage 58.05%
📏 4486 / 7617 lines covered 🌿 1086 / 1982 branches covered
🔍 click here for more details

✏️ updated for commit 6dc5067

@chrimesdev chrimesdev enabled auto-merge September 5, 2025 08:17
@chrimesdev chrimesdev requested a review from Copilot September 5, 2025 10:43

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken test infrastructure and improves test configuration for the Cohort Manager application by migrating from legacy test patterns to a modern Playwright BDD framework.

  • Refactored existing feature tests from legacy step definitions to modern Playwright BDD approach
  • Updated test configuration to use HTTP instead of HTTPS and simplified browser testing
  • Added unit tests to the CI workflow and consolidated test commands

Reviewed Changes

Copilot reviewed 44 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/ci-ui-tests.yaml Updated CI workflow to include unit tests and simplified E2E test execution
application/CohortManager/src/Web/package.json Updated test scripts and added axe-playwright dependency for accessibility testing
application/CohortManager/src/Web/playwright.config.ts Switched from HTTPS to HTTP, added webServer configuration, and simplified browser testing
application/CohortManager/src/Web/tests/features/*.feature Migrated feature files from legacy patterns to modern BDD syntax
application/CohortManager/src/Web/tests/features/steps/steps.ts Complete rewrite of step definitions using modern Playwright BDD patterns
Various component files Added test IDs and fixed minor bugs to support new test framework
Files not reviewed (1)
  • application/CohortManager/src/Web/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread application/CohortManager/src/Web/tests/features/steps/steps.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 9, 2025

@chrimesdev chrimesdev added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit c3f3fff Sep 9, 2025
67 checks passed
@chrimesdev chrimesdev deleted the tests/fix-tests branch September 9, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants