fix: fix broken tests, configuration and add unit tests#1556
Merged
chrimesdev merged 28 commits intomainfrom Sep 9, 2025
Merged
fix: fix broken tests, configuration and add unit tests#1556chrimesdev merged 28 commits intomainfrom
chrimesdev merged 28 commits intomainfrom
Conversation
b4d3b3c to
1650710
Compare
1650710 to
a3b7e53
Compare
a3b7e53 to
9527d1a
Compare
73db646 to
cf27b0c
Compare
6544aed to
6ae8267
Compare
91c8bbf to
39b52e1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken test infrastructure and improves test configuration for the Cohort Manager application by migrating from legacy test patterns to a modern Playwright BDD framework.
- Refactored existing feature tests from legacy step definitions to modern Playwright BDD approach
- Updated test configuration to use HTTP instead of HTTPS and simplified browser testing
- Added unit tests to the CI workflow and consolidated test commands
Reviewed Changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci-ui-tests.yaml |
Updated CI workflow to include unit tests and simplified E2E test execution |
application/CohortManager/src/Web/package.json |
Updated test scripts and added axe-playwright dependency for accessibility testing |
application/CohortManager/src/Web/playwright.config.ts |
Switched from HTTPS to HTTP, added webServer configuration, and simplified browser testing |
application/CohortManager/src/Web/tests/features/*.feature |
Migrated feature files from legacy patterns to modern BDD syntax |
application/CohortManager/src/Web/tests/features/steps/steps.ts |
Complete rewrite of step definitions using modern Playwright BDD patterns |
| Various component files | Added test IDs and fixed minor bugs to support new test framework |
Files not reviewed (1)
- application/CohortManager/src/Web/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
39b52e1 to
93df3db
Compare
e026b47 to
cdec259
Compare
cdec259 to
b374aa4
Compare
68d2f00 to
6248b5d
Compare
|
Warren-Pitterson
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes broken test infrastructure and improves test configuration for the Cohort Manager application by migrating from legacy test patterns to a modern Playwright BDD framework.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.