test: Rule 8 transformations#1542
Merged
Joseph2910 merged 16 commits intomainfrom Sep 2, 2025
Merged
Conversation
Contributor
will-larkin-nhs
left a comment
will-larkin-nhs
left a comment
There was a problem hiding this comment.
the ticket is just for changes to rule 8, do you have a ticket for the changes to the lookup rules?
|
MWClayson-NHS
approved these changes
Sep 2, 2025
adamsheldon1
approved these changes
Sep 2, 2025
ekpedemejames
approved these changes
Sep 2, 2025
stephhou
pushed a commit
that referenced
this pull request
Sep 5, 2025
* feat: Update rule 8 transformation * test: Add playwright tests for rule 8 * fix: Test file names * chore: Simplify transform rule * chore: Add in rule8 tests to runner * fix: Updated some tests * chore: delete unused tests * chore: Small fixes * chore: push debug * fix: Remove logging * fix lookup methods * chore: Add Terraform and Docker * fix: update Unit test signature * fix: Test --------- Co-authored-by: Michael Clayson <michael.clayson1@nhs.net>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-9935
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.