feat: GetExceptionsByReportDate

application/CohortManager/src/Functions/Shared/Common/HttpParserHelper.cs

@@ -1,5 +1,6 @@
 namespace Common;
 
+using System.Globalization;
 using System.Net;
 using Common.Interfaces;
 using Microsoft.Azure.Functions.Worker.Http;
@@ -69,4 +70,45 @@ public static T GetEnumQueryParameter<T>(HttpRequestData req, string key, T defa
 
         return Enum.TryParse<T>(queryString, true, out var result) ? result : defaultValue;
     }
+
+    /// <summary>
+    /// Parses a DateTime query parameter from the request. Supports various date formats.
+    /// </summary>
+    /// <param name="req">The HTTP request data</param>
+    /// <param name="key">The query parameter key name</param>
+    /// <returns>The parsed DateTime value or null if parsing fails or parameter is missing</returns>
+    public DateTime? GetQueryParameterAsDateTime(HttpRequestData req, string key)
+    {
+        var queryString = req.Query[key];
+
+        if (string.IsNullOrWhiteSpace(queryString))
+        {
+            return null;
+        }
+
+        string[] formats = {
+        "yyyy-MM-dd",
+        "yyyy/MM/dd",
+        "dd/MM/yyyy",
+        "dd-MM-yyyy",
+        "MM/dd/yyyy",
+        "MM-dd-yyyy",
+        "yyyy-MM-ddTHH:mm:ss",
+        "yyyy-MM-ddTHH:mm:ssZ",
+        "yyyy-MM-dd HH:mm:ss"
+    };
+
+        if (DateTime.TryParse(queryString, CultureInfo.InvariantCulture, DateTimeStyles.None, out DateTime result))
+        {
+            return result;
+        }
+
+        if (DateTime.TryParseExact(queryString, formats, CultureInfo.InvariantCulture, DateTimeStyles.None, out result))
+        {
+            return result;
+        }
+
+        _logger.LogWarning("Failed to parse date parameter '{Key}' with value '{Value}'", key, queryString);
+        return null;
+    }
 }

application/CohortManager/src/Functions/Shared/Common/Interfaces/IHttpParserHelper.cs

@@ -7,4 +7,5 @@ public interface IHttpParserHelper
     HttpResponseData LogErrorResponse(HttpRequestData req, string errorMessage);
     int GetQueryParameterAsInt(HttpRequestData req, string key, int defaultValue = 0);
     bool GetQueryParameterAsBool(HttpRequestData req, string key, bool defaultValue = false);
+    DateTime? GetQueryParameterAsDateTime(HttpRequestData req, string key);
 };

application/CohortManager/src/Functions/Shared/Common/Pagination/IPaginationService.cs

@@ -5,5 +5,5 @@ namespace Common;
 public interface IPaginationService<T>
 {
     PaginationResult<T> GetPaginatedResult(IQueryable<T> source, int? lastId, Func<T, int>? idSelector = null);
-    Dictionary<string, string> BuildPaginationHeaders<TEntity>(HttpRequestData request, PaginationResult<TEntity> paginationResult);
+    Dictionary<string, string> AddNavigationHeaders<TEntity>(HttpRequestData request, PaginationResult<TEntity> paginationResult);
 }

application/CohortManager/src/Functions/Shared/Common/Pagination/PaginationService.cs

@@ -29,7 +29,7 @@ public PaginationResult<T> GetPaginatedResult(IQueryable<T> source, int? lastId,
         }
 
         var items = source.Take(pageSize).ToList();
-        int? lastResultId = items.Count > 0 ? idSelector(items[items.Count - 1]) : null;
+        int? lastResultId = items.Count > 0 ? idSelector(items[^1]) : null;
 
         return new PaginationResult<T>
         {
@@ -39,11 +39,14 @@ public PaginationResult<T> GetPaginatedResult(IQueryable<T> source, int? lastId,
             LastResultId = lastResultId,
             TotalItems = totalItems,
             TotalPages = totalPages,
-            CurrentPage = currentPage
+            CurrentPage = currentPage,
         };
     }
 
-    public Dictionary<string, string> BuildPaginationHeaders<TEntity>(HttpRequestData request, PaginationResult<TEntity> paginationResult)
+    /// <summary>
+    /// Adds pagination navigation headers to the response.
+    /// </summary>
+    public Dictionary<string, string> AddNavigationHeaders<TEntity>(HttpRequestData request, PaginationResult<TEntity> paginationResult)
     {
         var headers = new Dictionary<string, string>
         {
@@ -100,15 +103,16 @@ private static string RemoveLastIdParam(string queryString)
 
     private static Func<T, int> GetDefaultIdSelector()
     {
-        var idProperty = typeof(T).GetProperty("Id") ??
-            typeof(T).GetProperty($"{typeof(T).Name}Id");
-
-        if (idProperty == null)
-        {
+        var idProperty = (typeof(T).GetProperty("Id") ??
+            typeof(T).GetProperty($"{typeof(T).Name}Id")) ??
             throw new InvalidOperationException(
                 "Could not find a default ID property. Provide a custom ID selector.");
-        }
 
-        return x => (int)idProperty.GetValue(x);
+        return x =>
+        {
+            var value = idProperty.GetValue(x) ?? throw new InvalidOperationException(
+                    $"Entity of type {typeof(T).Name} has a null ID property ('{idProperty.Name}').");
+            return (int)value;
+        };
     }
 }

application/CohortManager/src/Functions/Shared/Data/Database/IValidationExceptionData.cs

@@ -11,4 +11,5 @@ public interface IValidationExceptionData
     Task<ValidationException?> GetExceptionById(int exceptionId);
     Task<bool> RemoveOldException(string nhsNumber, string screeningName);
     Task<ServiceResponseModel> UpdateExceptionServiceNowId(int exceptionId, string serviceNowId);
+    Task<List<ValidationException>?> GetReportExceptions(DateTime? reportDate, ExceptionCategory exceptionCategory);
 }

application/CohortManager/src/Functions/Shared/Data/Database/ValidationExceptionData.cs

@@ -120,6 +120,42 @@ public async Task<ServiceResponseModel> UpdateExceptionServiceNowId(int exceptio
         }
     }
 
+    public async Task<List<ValidationException>?> GetReportExceptions(DateTime? reportDate, ExceptionCategory exceptionCategory)
+    {
+        if (exceptionCategory is not (ExceptionCategory.Confusion or ExceptionCategory.Superseded or ExceptionCategory.NBO))
+        {
+            return [];
+        }
+
+        var filteredExceptions = (await _validationExceptionDataServiceClient.GetByFilter(x =>
+            x.Category.HasValue && (x.Category.Value == (int)ExceptionCategory.Confusion || x.Category.Value == (int)ExceptionCategory.Superseded)))?.AsEnumerable();
+
+        if (exceptionCategory == ExceptionCategory.Confusion || exceptionCategory == ExceptionCategory.Superseded)
+        {
+            filteredExceptions = filteredExceptions?.Where(x => x.Category.HasValue && x.Category.Value == (int)exceptionCategory);
+        }
+
+        if (reportDate.HasValue)
+        {
+            var startDate = reportDate.Value.Date;
+            var endDate = startDate.AddDays(1);
+            filteredExceptions = filteredExceptions?.Where(x => x.DateCreated >= startDate && x.DateCreated < endDate);
+        }
+
+        if (filteredExceptions?.Any() != true)
+            return [];
+
+        var tasks = filteredExceptions.Select(async exception =>
+        {
+            var validationException = exception.ToValidationException();
+            var participantDemographic = long.TryParse(exception.NhsNumber, out long nhsNumber) ? await _demographicDataServiceClient.GetSingleByFilter(x => x.NhsNumber == nhsNumber) : null;
+            return GetExceptionDetails(validationException, participantDemographic);
+        });
+
+        var results = await Task.WhenAll(tasks);
+        return results.Where(x => x != null).ToList()!;
+    }
+
     private ServiceResponseModel CreateResponse(bool success, HttpStatusCode statusCode, string message)
     {
         if (!success)
@@ -187,7 +223,7 @@ private ServiceResponseModel CreateResponse(bool success, HttpStatusCode statusC
     {
 
         var exceptions = await _validationExceptionDataServiceClient.GetByFilter(x => x.NhsNumber == nhsNumber && x.ScreeningName == screeningName);
-        return exceptions != null ? exceptions.ToList() : null;
+        return exceptions?.ToList();
 
     }
 

application/CohortManager/src/Functions/screeningDataServices/GetValidationExceptions/GetValidationExceptions.cs

@@ -13,17 +13,9 @@ namespace NHS.CohortManager.ScreeningDataServices;
 using Model.Enums;
 
 /// <summary>
-/// Azure Function for retrieving cohort distribution data based on ScreeningServiceId.
+/// Azure Function for retrieving and managing validation exceptions.
+/// Provides endpoints for exception queries, reports, and ServiceNowId updates.
 /// </summary>
-/// <param name="req">The HTTP request data containing query parameters and request details.</param>
-/// <param name="exceptionId">query parameter used to search for an exception by Id..</param>
-/// if not exceptionId is passed in the full list of exceptions will be returned
-/// <returns>
-/// HTTP response with:
-/// - 204 No Content if no data is found.
-/// - 200 OK - List<GetValidationExceptions> or single GetValidationExcept in JSON format .
-/// - 500 Internal Server Error if an exception occurs.
-/// </returns>
 public class GetValidationExceptions
 {
     private readonly ILogger<GetValidationExceptions> _logger;
@@ -32,7 +24,6 @@ public class GetValidationExceptions
     private readonly IHttpParserHelper _httpParserHelper;
     private readonly IPaginationService<ValidationException> _paginationService;
 
-
     public GetValidationExceptions(ILogger<GetValidationExceptions> logger, ICreateResponse createResponse, IValidationExceptionData validationData, IHttpParserHelper httpParserHelper, IPaginationService<ValidationException> paginationService)
     {
         _logger = logger;
@@ -42,6 +33,15 @@ public GetValidationExceptions(ILogger<GetValidationExceptions> logger, ICreateR
         _paginationService = paginationService;
     }
 
+    /// <summary>
+    /// Retrieves validation exceptions based on query parameters.
+    /// Supports single exception lookup, filtered lists, and report-based queries.
+    /// </summary>
+    /// <param name="req">The HTTP request data containing query parameters.</param>
+    /// <returns>
+    /// HTTP response containing validation exceptions in JSON format.
+    /// Returns 200 OK with data, 204 No Content if empty, 400 Bad Request for validation errors, or 500 Internal Server Error.
+    /// </returns>
     [Function(nameof(GetValidationExceptions))]
     public async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymous, "get")] HttpRequestData req)
     {
@@ -50,33 +50,32 @@ public async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymou
         var exceptionStatus = HttpParserHelper.GetEnumQueryParameter(req, "exceptionStatus", ExceptionStatus.All);
         var sortOrder = HttpParserHelper.GetEnumQueryParameter(req, "sortOrder", SortOrder.Descending);
         var exceptionCategory = HttpParserHelper.GetEnumQueryParameter(req, "exceptionCategory", ExceptionCategory.NBO);
+        var reportDate = _httpParserHelper.GetQueryParameterAsDateTime(req, "reportDate");
+        var isReport = _httpParserHelper.GetQueryParameterAsBool(req, "isReport");
 
         try
         {
             if (exceptionId > 0)
             {
                 var exceptionById = await _validationData.GetExceptionById(exceptionId);
                 return exceptionById == null
-                    ? _createResponse.CreateHttpResponse(HttpStatusCode.NoContent, req)
-                    : _createResponse.CreateHttpResponse(HttpStatusCode.OK, req, JsonSerializer.Serialize(exceptionById));
+                ? _createResponse.CreateHttpResponse(HttpStatusCode.NoContent, req)
+                : _createResponse.CreateHttpResponse(HttpStatusCode.OK, req, JsonSerializer.Serialize(exceptionById));
             }
 
-            var allExceptions = await _validationData.GetAllFilteredExceptions(exceptionStatus, sortOrder, exceptionCategory);
-
-            if (allExceptions == null)
+            if (isReport)
             {
-                return _createResponse.CreateHttpResponse(HttpStatusCode.NoContent, req);
-            }
+                if (reportDate.HasValue && reportDate.Value > DateTime.Now.Date)
+                {
+                    return _createResponse.CreateHttpResponse(HttpStatusCode.BadRequest, req, "Report date cannot be in the future.");
+                }
 
-            var paginatedResult = _paginationService.GetPaginatedResult(allExceptions.AsQueryable(), lastId == 0 ? null : lastId, e => e.ExceptionId);
-            if (!paginatedResult.Items.Any())
-            {
-                return _createResponse.CreateHttpResponse(HttpStatusCode.NoContent, req);
+                var reportExceptions = await _validationData.GetReportExceptions(reportDate, exceptionCategory);
+                return CreatePaginatedResponse(req, reportExceptions, lastId);
             }
 
-            var headers = _paginationService.BuildPaginationHeaders(req, paginatedResult);
-
-            return _createResponse.CreateHttpResponseWithHeaders(HttpStatusCode.OK, req, JsonSerializer.Serialize(paginatedResult.Items), headers);
+            var allExceptions = await _validationData.GetAllFilteredExceptions(exceptionStatus, sortOrder, exceptionCategory);
+            return CreatePaginatedResponse(req, allExceptions, lastId);
         }
         catch (Exception ex)
         {
@@ -85,16 +84,28 @@ public async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymou
         }
     }
 
+
+    private HttpResponseData CreatePaginatedResponse(HttpRequestData req, List<ValidationException>? exceptions, int lastId)
+    {
+        if (exceptions == null || exceptions.Count == 0)
+        {
+            return _createResponse.CreateHttpResponse(HttpStatusCode.NoContent, req);
+        }
+
+        var paginatedResult = _paginationService.GetPaginatedResult(exceptions.AsQueryable(), lastId == 0 ? null : lastId, e => e.ExceptionId);
+
+        if (!paginatedResult.Items.Any())
+        {
+            return _createResponse.CreateHttpResponse(HttpStatusCode.NoContent, req);
+        }
+
+        var headers = _paginationService.AddNavigationHeaders(req, paginatedResult);
+        return _createResponse.CreateHttpResponseWithHeaders(HttpStatusCode.OK, req, JsonSerializer.Serialize(paginatedResult), headers);
+    }
+
     /// <summary>
-    /// Updates the ServiceNow ID for a specific validation exception.
+    /// Updates the ServiceNowId for a specific validation exception.
     /// </summary>
-    /// <param name="req">The HTTP request data containing the exception ID and ServiceNow ID.</param>
-    /// <returns>
-    /// HTTP response with:
-    /// - 200 OK if the update is successful
-    /// - 400 Bad Request if required parameters are missing
-    /// - 500 Internal Server Error if an exception occurs
-    /// </returns>
     [Function(nameof(UpdateExceptionServiceNowId))]
     public async Task<HttpResponseData> UpdateExceptionServiceNowId([HttpTrigger(AuthorizationLevel.Anonymous, "put")] HttpRequestData req)
     {