fix: now allows for dummy postcode ZZZSECUR in transform#1477
Merged
SamRobinson75684 merged 10 commits intomainfrom Aug 13, 2025
Merged
fix: now allows for dummy postcode ZZZSECUR in transform#1477SamRobinson75684 merged 10 commits intomainfrom
SamRobinson75684 merged 10 commits intomainfrom
Conversation
…github.com/NHSDigital/dtos-cohort-manager into fix/DTOSS-10107-postcode-validation-bypass
…not effected and can run properly
Contributor
will-larkin-nhs
left a comment
will-larkin-nhs
left a comment
There was a problem hiding this comment.
I would prefer that we handle this in validate outcode as a guard clause if the postcode starts with ZZ we just return false. I understand wanting to keep it all in one place but now with the ZZZSECUR postcodes I don't think it makes sense to call the parse outcode method because there is no outcode to parse. So I think if the postcode starts with ZZ we should just skip the DB call and the parse outcode method
|
will-larkin-nhs
approved these changes
Aug 13, 2025
MWClayson-NHS
approved these changes
Aug 13, 2025
SamRobinson75684
deleted the
Fix/DTOSS-10107-postcode-validation-bypass
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10107
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10617
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.