Skip to content

fix: add supersededByNhsNumber and clean up mock data#1467

Merged
chrimesdev merged 3 commits intomainfrom
fix/dummy-data
Aug 13, 2025
Merged

fix: add supersededByNhsNumber and clean up mock data#1467
chrimesdev merged 3 commits intomainfrom
fix/dummy-data

Conversation

@chrimesdev
Copy link
Copy Markdown
Member

@chrimesdev chrimesdev commented Aug 12, 2025

Description

Adds supersededByNhsNumber to the UI mock data following the changes to the API, to allow for testing. Also clean up some of the data that we don't use in the UI in the mock API response (FileName/ErrorRecord)

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 12, 2025

Unit Test Results

✔️ Tests 744 / 744 - passed in 12.3s
📝 Coverage 56.03%
📏 4083 / 7186 lines covered 🌿 973 / 1838 branches covered
🔍 click here for more details

✏️ updated for commit 2572c59

@chrimesdev chrimesdev enabled auto-merge August 12, 2025 12:04
@sonarqubecloud
Copy link
Copy Markdown

@chrimesdev chrimesdev added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit 7ef6c7e Aug 13, 2025
64 checks passed
@chrimesdev chrimesdev deleted the fix/dummy-data branch August 13, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants