Skip to content

feat: added SupersededByNhsNumber to ExceptionDetails and changed pagination from 20 to 10 results per page #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Warren-Pitterson merged 1 commit into from
Aug 12, 2025
Merged

feat: added SupersededByNhsNumber to ExceptionDetails and changed pagination from 20 to 10 results per page #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions application/CohortManager/src/Functions/Shared/Common/Pagination/PaginationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ namespace Common;

public class PaginationService<T> : IPaginationService<T>
{
private const int pageSize = 20;
private const int pageSize = 10;

public PaginationResult<T> GetPaginatedResult(
IQueryable<T> source,
Expand All @@ -19,7 +19,7 @@ public PaginationResult<T> GetPaginatedResult(
var idList = source.Select(idSelector).OrderBy(id => id).ToList();

// Get the index of the lastId
int lastIdIndex = lastId.HasValue? idList.IndexOf(lastId.Value) : -1;
int lastIdIndex = lastId.HasValue ? idList.IndexOf(lastId.Value) : -1;
int currentPage = lastIdIndex >= 0 ? (lastIdIndex / pageSize) + 2 : 1;
var totalItems = source.Count();
var totalPages = (int)Math.Ceiling((double)totalItems / pageSize);
Expand Down
3 changes: 2 additions & 1 deletion application/CohortManager/src/Functions/Shared/Data/Database/ValidationExceptionData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ public async Task<bool> UpdateExceptionServiceNowId(int exceptionId, string serv
ParticipantPostCode = participantDemographic?.PostCode,
TelephoneNumberHome = participantDemographic?.TelephoneNumberHome,
EmailAddressHome = participantDemographic?.EmailAddressHome,
PrimaryCareProvider = participantDemographic?.PrimaryCareProvider
PrimaryCareProvider = participantDemographic?.PrimaryCareProvider,
SupersededByNhsNumber = participantDemographic?.SupersededByNhsNumber,
};

if (participantDemographic == null)
Expand Down
1 change: 1 addition & 0 deletions application/CohortManager/src/Functions/Shared/Model/ExceptionDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ public class ExceptionDetails
public string? EmailAddressHome { get; set; }
public string? PrimaryCareProvider { get; set; }
public Gender? Gender { get; set; }
public long? SupersededByNhsNumber { get; set; }
}
Loading