fix: RetrievePdsDemographic API to return PdsDemographic objects instead of ParticipantDemographic#1462
Merged
SamAinsworth-NHS merged 7 commits intomainfrom Aug 12, 2025
Conversation
…pdate to convert objects before processing.
…ticipantDemographic - update all downstream
alex-clayton-1
approved these changes
Aug 12, 2025
SamRobinson75684
approved these changes
Aug 12, 2025
|
SamAinsworth-NHS
deleted the
Fix/retrieve-pds-demo-to-demographic-response
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an architectural improvement to the RetrievePdsDemographic API to return
PdsDemographicobjects instead ofParticipantDemographicobjects, ensuring type consistency and resolving JSON deserialization errors.The RetrievePdsDemographic function was incorrectly returning
ParticipantDemographicobjects (whereParticipantIdis along) instead ofPdsDemographicobjects (where properties are strings). This caused JSON deserialization errors in ProcessNemsUpdate.Changes made include updating the API response serialisation, updating all consuming functions to work with
PdsDemographicobjects, adding method overloading for backward compatibility, and fixing all test mocks to use the correct types.Context
The RetrievePdsDemographic function name suggests it returns
PdsDemographicobjects, but it was actually returningParticipantDemographicobjects. This type mismatch caused JSON deserialisation failures in ProcessNemsUpdate function that expected string-based properties but received numeric values for fields likeParticipantId.This architectural inconsistency needed to be resolved to ensure proper API contract adherence and eliminate runtime errors.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.