Skip to content

chore: adding unit tests for PDS functionality#1452

Merged
SamRobinson75684 merged 13 commits intomainfrom
fix/DTOSS-10515-Handling-not-found-in-pds-func
Aug 11, 2025
Merged

chore: adding unit tests for PDS functionality#1452
SamRobinson75684 merged 13 commits intomainfrom
fix/DTOSS-10515-Handling-not-found-in-pds-func

Conversation

@SamRobinson75684
Copy link
Copy Markdown
Contributor

@SamRobinson75684 SamRobinson75684 commented Aug 11, 2025

Description

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10515

  • adds a new class called "PdsProcessor" for better separation and testability
  • adds new tests for PDS functions
  • aims to keep the function body "tidy"

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 11, 2025

Unit Test Results

✔️ Tests 725 / 725 - passed in 12.7s
📝 Coverage 55.96%
📏 3940 / 6925 lines covered 🌿 931 / 1780 branches covered
🔍 click here for more details

✏️ updated for commit 58647a2

Comment thread tests/PdsProcessorTests/PdsProcessorTests.cs Outdated
Comment thread tests/PdsProcessorTests/PdsProcessorTests.cs Outdated
@SamRobinson75684 SamRobinson75684 added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 83bacb9 Aug 11, 2025
16 checks passed
@SamRobinson75684 SamRobinson75684 deleted the fix/DTOSS-10515-Handling-not-found-in-pds-func branch August 11, 2025 13:33
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants