fix: Retrieve PDS Demographic - Correct Service Bus connection string handling in configuration#1451
Merged
SamAinsworth-NHS merged 1 commit intomainfrom Aug 11, 2025
Conversation
Unit Test Results✔️ Tests 725 / 725 - passed in 10.9s |
|
MWClayson-NHS
approved these changes
Aug 11, 2025
SamRobinson75684
approved these changes
Aug 11, 2025
SamAinsworth-NHS
deleted the
Fix/retrieve-pds-demographic-service-bus-configuration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Service Bus connection string handling in the RetrievePDSDemographic function to provide more flexible configuration options. The changes add support for an alternative connection string environment variable (
ServiceBusConnectionString_client_internal) while maintaining backward compatibility with the existingServiceBusConnectionString.Context
The terraform setup explicitly sets the service bus connection string to ServiceBusConnectionString_client_internal - so this was not being picked up in Program.cs and preventing function startup
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.